Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging, use log.group in ProductControl (bsc#1204625) #1278

Merged
merged 2 commits into from Oct 25, 2022
Merged

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Oct 25, 2022

Problem

Review Notes

  • Use the "Hide whitespace" diff option otherwise the diff is too long and harder to read.
  • Simply use this link

Solution

  • Use the new log.group call and group the logs for each executed step

Testing

@coveralls
Copy link

coveralls commented Oct 25, 2022

Coverage Status

Coverage increased (+0.03%) to 41.719% when pulling 3f612ed on logging into 13d6af4 on master.

Copy link
Member

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

but the bad news is, now I have seen that RunFrom is a 300 line method 🤯

@lslezak lslezak merged commit a2c1a48 into master Oct 25, 2022
@lslezak lslezak deleted the logging branch October 25, 2022 15:20
@yast-bot
Copy link
Contributor

❌ Public Jenkins job #389 failed

@yast-bot
Copy link
Contributor

❌ Internal Jenkins job #213 failed

@yast-bot
Copy link
Contributor

❌ Public Jenkins job #390 failed

@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #391 successfully finished
✔️ Created OBS submit request #1031177

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #214 successfully finished
✔️ Created IBS submit request #283157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants