Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added usenbft and use fcoe to Linuxrc (jsc#PED-3138) #1284

Closed
wants to merge 2 commits into from

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Jan 26, 2023

Added some convenience method for detecting whether FCoE or NBFT disks activation config should be used or not.

@coveralls
Copy link

coveralls commented Jan 26, 2023

Coverage Status

Coverage: 41.735% (+0.008%) from 41.727% when pulling 5c7035c on added_linuxrc_usenbft into 7202cd8 on master.


- Aded Linuxrc.usenbft and Linuxrc.usefcoe convenience methods to
detects whether NBFT of FCoE disks activation should be called
(jsc#PED-3138, bsc#207573).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(jsc#PED-3138, bsc#207573).
(jsc#PED-3138, bsc#1207573).

@teclator
Copy link
Contributor Author

Finally we checked Linuxrc.InstallInf("UseNBFT") == "1" directly, so closing it by now as it was only for adding some convenience methods (see yast/yast-packager#635)

@teclator teclator closed this May 10, 2023
@dgdavid dgdavid deleted the added_linuxrc_usenbft branch May 10, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants