Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for the unmaintained GTK UI plugin #302

Merged
merged 1 commit into from
Nov 26, 2014
Merged

Remove support for the unmaintained GTK UI plugin #302

merged 1 commit into from
Nov 26, 2014

Conversation

gber
Copy link

@gber gber commented Nov 9, 2014

This removes support for the GTK UI plugin but leaves support for the GTK control center in, as requested in #301.

@gber
Copy link
Author

gber commented Nov 26, 2014

Can someone please review this, I think I addressed the issue raised in #301?

@jreidinger
Copy link
Member

@jsrain can you please check it?

@mvidner
Copy link
Member

mvidner commented Nov 26, 2014

A reference to Bugzilla or Fate is missing. I think bnc#901851 should be mentioned in .changes.

@gber
Copy link
Author

gber commented Nov 26, 2014

I think bnc#901511 is more suitable due to the discussion there and it being referenced in the release notes as well. I've updated it accordingly.

@mvidner
Copy link
Member

mvidner commented Nov 26, 2014

LGTM, merging.
Thank you, Guido!

mvidner added a commit that referenced this pull request Nov 26, 2014
Remove support for the unmaintained GTK UI plugin
@mvidner mvidner merged commit 5903803 into yast:master Nov 26, 2014
@mvidner
Copy link
Member

mvidner commented Nov 26, 2014

@gber concerning applying this as a maintenance update for 13.2, it is not as simple as only using this code. People would suddenly get the ncurses UI instead of the GTK UI even in cases where they had no problems with GTK.

@gber
Copy link
Author

gber commented Nov 26, 2014

In 13.2 the x11_yast pattern recommends libyiu-pkg-qt6 which requires libyiu-qt6, the x11_yast pattern also supplements the x11 and yast2_basis patterns. All desktop patterns either depend on the latter two patterns or directly on x11_yast, also note that both the KDE and GNOME patterns already default to Qt anyway, so AFAICS this should not be a problem in practice?

@gber
Copy link
Author

gber commented Dec 3, 2014

@mvidner So, given the above, can you please elaborate? Otherwise I'd really like to push an update to 13.2 rather than leaving people with a broken YaST frontend for which any bug reports will be ignored (and given the stuff that is on b.o.o I think it is impossible not to have problems with GTK if you use the GUI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants