[WIP] Support for unsigned repositories (bsc#1009127) #537
Conversation
lslezak
commented
Feb 7, 2017
•
lslezak
commented
lslezak
force-pushed
the
unsigned_repo
branch
from
7cf8bbc
to
5230ce2
Compare
There was a problem hiding this comment.
codewise change looks good, but I have one problem. with adding more lines, now method is too long to my taste ( it was even before and now we make it even worse ). Is some refactoring possible to have reasonable size?
e.g description text or again widget would be nice to be separated method.
And second note, is tests possible for this method? I think currently it is not covered at all and would be nice if we can improve it.
|
Yes, this is just PoC, we need to discuss the solution with the security team first, maybe at the end we will need a better solution directly on the libzypp level. Let's see... |
|
@lslezak do you plan to do something with this PR? if not, just close it by now |
|
@lslezak yast/yast-packager#230 (comment) Feel free to reopen it if do you plan to work on it. |
