bsc#1036440: Warning messages shouldn't open UI in command-line mode

[gilsonsouza]

No description provided.

[coveralls]

Coverage decreased (-0.004%) to 58.734% when pulling b72de08 on gilsonsouza:SLE-12-SP1 into 575c145 on yast:SLE-12-SP1.

[imobachgs]

The code looks good, but I am missing some test cases. Please, check report_test.rb and try to add some test cases.

[coveralls]

Coverage increased (+0.3%) to 59.019% when pulling 214b168 on gilsonsouza:SLE-12-SP1 into 575c145 on yast:SLE-12-SP1.

[coveralls]

Coverage increased (+0.3%) to 59.019% when pulling cf4831c on gilsonsouza:SLE-12-SP1 into 575c145 on yast:SLE-12-SP1.

[coveralls]

Coverage increased (+0.3%) to 59.019% when pulling c6dafdc on gilsonsouza:SLE-12-SP1 into 575c145 on yast:SLE-12-SP1.

[imobachgs]

Just for consistence, I would use :Warning symbol instead of the string.

[imobachgs]

If you are going to mock Yast::Mode.commandline in all cases, maybe you would like to move it to a before block and just define the value for each case.

before do
  allow(Yast::Mode).to receive(:commandline).and_return(commandline?)
end

context "while in UI mode and timeout is disabled" do
  let(:timeout) { 0 }
  let(:commandline?) { false }

  it "shows a popup" do
    #...
  end
end

[imobachgs]

Same than above. I would move this line to the outer before block.

[imobachgs]

We usually write it like this:

- Warning messages shouldn't open UI in command-line mode (bsc#1036440)

[coveralls]

Coverage increased (+0.3%) to 59.024% when pulling d06a6f6 on gilsonsouza:SLE-12-SP1 into 575c145 on yast:SLE-12-SP1.

[coveralls]

Coverage increased (+0.3%) to 59.024% when pulling 369bc5e on gilsonsouza:SLE-12-SP1 into 575c145 on yast:SLE-12-SP1.

[coveralls]

Coverage increased (+0.3%) to 59.024% when pulling ef4a4f3 on gilsonsouza:SLE-12-SP1 into 575c145 on yast:SLE-12-SP1.

[imobachgs]

Thanks for these tests!