Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix object wrapper usage #600

Merged
merged 3 commits into from Jul 20, 2017
Merged

Fix object wrapper usage #600

merged 3 commits into from Jul 20, 2017

Conversation

jreidinger
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 28.379% when pulling f101151 on fix_object_wrapper_usage into b5709f8 on master.

mvidner
mvidner reviewed Jul 20, 2017
View reviewed changes
Copy link
Member

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All values being "test" in the test is too much! Better use nil!

Now it LGTM

library/cwm/test/wrapper_widget_test.rb Outdated
end

it "return hash that has _cwm_key key with widget id" do
content = { "test" => "test" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"test -> test" is bad test data, as it can be fooled by stupid mistakes in the implementation (map{ |k, v| [k, k] })
so "key" -> "value" would be better

@jreidinger jreidinger merged commit f1795f2 into master Jul 20, 2017
@jreidinger jreidinger deleted the fix_object_wrapper_usage branch July 20, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvidner mvidner mvidner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jreidinger @coveralls @mvidner