Point users of CWMServiceStart to the replacement API. #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
reviewed
Jul 27, 2017
| require "yast" | ||
|
|
||
| module Yast | ||
| # Routines for service start widget handling. | ||
| # | ||
| # NOTE: a modern API for this is {::UI::ServiceStatus} |
There was a problem hiding this comment.
what about marking it as deprecated and replaced by that?
There was a problem hiding this comment.
Well, I wasn't confident about that, but since that time I had to look into systemctl anyway, so I'll check again and add more docs about how to migrate to the new API.
|
@mvidner @jreidinger some months have passed since last comments, so what about merging current changes until we are able to mark it as deprecated and add more doc about how to migrate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lingshan just asked about CWMServiceStart and it took me a while to find the modern API, so here's a shortcut.