log calculated proposal in yaml format into separate files (fate#318196) #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at y2log alone is not helpful. Log the devicegraph into human-readable files.
jreidinger
requested changes
Oct 30, 2017
There was a problem hiding this comment.
I think this is really wrong place to have it. ProposalClient is generic parent for any proposal client. And here it always logs using y2storage its device graph. So it
- require yast2-storage to be always installed for yast2
- writes device graph many times
So I really suggest to modify instead https://github.com/yast/yast-storage-ng/blob/master/src/lib/y2storage/clients/partitions_proposal.rb#L61which is storage only proposal code.
|
@wfeldt what is the state of this PR? still valid? or not make sense anymore? |
|
Let's close it in view of Josef's comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at y2log alone is not helpful. Log the devicegraph into
human-readable files.