Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Firewalld fixes for the new UI #813

Closed
wants to merge 1 commit into from
Closed

[WIP] Firewalld fixes for the new UI #813

wants to merge 1 commit into from

Conversation

mvidner
Copy link
Member

@mvidner mvidner commented Sep 3, 2018 •
edited
Loading

TODO: when firewalld is running, the unit tests cause a Polkit pop-up

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 29.551% when pulling a292631 on fw-interfaces-read into 6c101da on SLE-15-GA.

@teclator
Copy link
Contributor

teclator commented Sep 4, 2018 •
edited
Loading

I would expect in both cases to be already read. Adding this extra checks probably will be more secure although it is an extra responsibility

@mvidner mvidner mentioned this pull request Sep 10, 2018
Merged
@mvidner
Copy link
Member Author

mvidner commented Sep 24, 2020

This is a robustness improvement that did not make it in its time. RIP.

@mvidner mvidner closed this Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvidner @coveralls @teclator