Return zone object

[imobachgs]

• Y2Firewall::Firewalld::Interface#zone returns an object.
• Add unit tests to the class.

[teclator]

It looks good, but CWMFirewallInterfaces probably will need to be adapted too

https://github.com/yast/yast-yast2/blob/master/library/network/src/modules/CWMFirewallInterfaces.rb#L254

[coveralls]

Coverage increased (+0.002%) to 30.489% when pulling 29ff142 on return-zone-object into 3aad6db on SLE-15-GA.

[teclator]

Something like:

--- a/library/network/src/modules/CWMFirewallInterfaces.rb
+++ b/library/network/src/modules/CWMFirewallInterfaces.rb
@@ -251,7 +251,7 @@ module Yast
       zones =
         known_interfaces.each_with_object([]) do |known_interface, a|
           if allowed_interfaces.include?(known_interface.name)
-            zone_name = known_interface.zone || firewalld.default_zone
+            zone_name = known_interface.zone ? known_interface.zone.name : firewalld.default_zone
             a << zone_name
           end
         end
diff --git a/library/network/test/test_helper.rb b/library/network/test/test_helper.rb
index a62c678c..e52b4e8b 100644
--- a/library/network/test/test_helper.rb
+++ b/library/network/test/test_helper.rb
@@ -82,7 +82,8 @@ module NetworkStubs
   }.freeze
 end
 
-def mock_firewalld_interface(id, name, zone)
+def mock_firewalld_interface(id, name, zone_name)
+  zone = instance_double("Y2Firewall::Firewalld::Zone", name: zone_name)
   instance_double("Y2Firewall::Firewalld::Interface",
     id: id, name: id.to_s, device_name: name, zone: zone)
 end

[teclator]

LGTM

[teclator]

We missed to adapt the interface_zone helper method