Do not modify the value if it is the same. #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
commented
Oct 1, 2018
| @@ -183,6 +184,7 @@ def has_many(*relations, scope: nil, cache: false) # rubocop:disable Style/Predi | |||
| attr_reader relation | |||
|
|
|||
| define_method "#{relation}=" do |item| | |||
| return item if public_send(relation) == item | |||
There was a problem hiding this comment.
It could be improved, doing a sort of the items but will need other checks, so not added by now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix for http://bugzilla.suse.com/show_bug.cgi?id=1109812
The bug appeared because this change:
https://github.com/yast/yast-yast2/pull/818/files#diff-d15e2fb4c53a9dc67f63ddf07c2b6aaeL148
Now we do not check current value when writing, with this change we should not mark it as modified if the value is the same.