Make the service status label stretchable (bsc#1110407) #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the updated status is displayed correctly - 4.1.20
jreidinger
reviewed
Oct 2, 2018
| Label(" "), | ||
| Label(Id(:service_widget_status), status) | ||
| HSpacing(1), | ||
| Label(Id(:service_widget_status), Opt(:hstretch), status) |
There was a problem hiding this comment.
what is exactly problem? In past I see similar issue with CWM and correct solution should be usage of UI.RecalcLayout https://yast-ui-bindings.surge.sh/classYCP__UI.html#a7da317092ab6d90ca7bbfe06c196b54d
There was a problem hiding this comment.
You need to add a hook to the change event, moreover it recalculates the whole layout which is not trivial. This only affects the label.
jreidinger
approved these changes
Oct 2, 2018
|
✔️ Public Jenkins job #37 successfully finished |
|
❌ Internal Jenkins job #43 failed |
|
✔️ Internal Jenkins job #44 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HSpacing(1)instead ofLabel(" ")- if there is lack of space libyui first decreases/removes the spacings, this might be enough without cutting off the labels