Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Yast::Execute API #876

Merged
merged 3 commits into from
Dec 17, 2018
Merged

Extend Yast::Execute API #876

merged 3 commits into from
Dec 17, 2018

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Dec 13, 2018 •
edited
Loading

Related to PBI: https://trello.com/c/AzEDChwZ/520-issues-from-yast-audit-systemlog-backtickslog

Yast::Execute.locally!.stdout(...)
Yast::Execute.on_target!.stdout(...)
Yast::Execute.stdout(...)

@coveralls
Copy link

coveralls commented Dec 13, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 27.066% when pulling c43b32c on joseivanlopez:extend_execute into 73803e3 on yast:master.

@joseivanlopez joseivanlopez force-pushed the extend_execute branch 2 times, most recently from fc37cbb to c2a5778 Compare December 14, 2018 09:50
@joseivanlopez joseivanlopez changed the title [RFC] Extend Yast::Execute API Extend Yast::Execute API Dec 14, 2018
@joseivanlopez joseivanlopez force-pushed the extend_execute branch 2 times, most recently from bd7d14f to faddc54 Compare December 14, 2018 14:33
@joseivanlopez
Extend Yast::Execute API
1872717 
- Add Yast::Execute.stdout
- Allows to chain methods: Yast::Execute.locally!.stdout
@joseivanlopez
Add unit tests
d197304
@joseivanlopez
Update version and changelog
c43b32c
@joseivanlopez joseivanlopez mentioned this pull request Dec 17, 2018
Merged
dgdavid
dgdavid approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@joseivanlopez joseivanlopez merged commit f0c06b3 into yast:master Dec 17, 2018
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #61 successfully finished
✔️ Created OBS submit request #658872

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #68 successfully finished
✔️ Created IBS submit request #180123

@joseivanlopez joseivanlopez mentioned this pull request Dec 17, 2018
Merged
@dgdavid dgdavid mentioned this pull request Jan 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvidner mvidner mvidner left review comments

@jreidinger jreidinger jreidinger approved these changes

@dgdavid dgdavid dgdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@joseivanlopez @coveralls @yast-bot @mvidner @jreidinger @dgdavid