Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invoking yast modules without arguments (bsc#1121425) #887

Merged
merged 2 commits into from
Jan 10, 2019
Merged

fix invoking yast modules without arguments (bsc#1121425) #887

merged 2 commits into from
Jan 10, 2019

Conversation

jreidinger
Copy link
Member

@jreidinger jreidinger commented Jan 10, 2019 •
edited by dgdavid
Loading

Fix bsc#1121425

when using yast in ncurses mode, opening many of its modules make Yast actually just return to the main view of all modules and an error is printed on the terminal

Solution: does not pass empty argument, which makes module think it is CLI

dgdavid
dgdavid approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dgdavid
dgdavid approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

coveralls commented Jan 10, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.003%) to 27.909% when pulling 3d4f4f4 on fix_menu_invocation into 3b2406c on master.

@jreidinger jreidinger merged commit b3cccbc into master Jan 10, 2019
@jreidinger jreidinger deleted the fix_menu_invocation branch January 10, 2019 14:54
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #78 successfully finished
✔️ Created IBS submit request #181293

@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #72 successfully finished
✔️ Created OBS submit request #664709

@mvidner mvidner mentioned this pull request Jan 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgdavid dgdavid dgdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jreidinger @coveralls @yast-bot @dgdavid