Cwm improvements2 #888
Cwm improvements2 #888
Conversation
…ith default title
library/cwm/src/lib/cwm/popup.rb
Outdated
| @@ -34,6 +36,12 @@ def should_open_dialog? | |||
| true | |||
| end | |||
|
|
|||
| # Popup does not allow nil, so overwrite Dialog default value. | |||
| # @return [String,nil] The dialog title. | |||
There was a problem hiding this comment.
If it does not allow nil, then the return should be modified accordingly, isn't it?
There was a problem hiding this comment.
yes, you are right. Nil cause libyui red warning.
|
979b0ff "allow dialogs and popups to have its help" - so, how should I do it when I want my own dialog/popup to have a help? Is that documented in a yard comment? For both classes? |
|
@mvidner popup is subclass of dialog, so I believe that having it only in dialog is enough. Documentation in dialog is missing. I overlook that I did not write it on friday and forgot to add it today. Will do it. Thanks for notice. |
|
LGTM |
|
✔️ Public Jenkins job #73 successfully finished |
|
✔️ Internal Jenkins job #79 successfully finished |
No description provided.