Fixed evaluating release notes

[lslezak]

Problem

• The ./y2packager/release_notes_fetchers/rpm_test.rb unit test randomly failed in OBS (see Fails to build with ruby 2.6 #895).

From a debugging session:

(byebug) p = File.join(directory, "**", "RELEASE-NOTES.{#{langs.join(",")}}.#{prefs.format}")
"/tmp/d20190215-22316-ra8tss/**/RELEASE-NOTES.{de_DE,de,en}.txt"
(byebug) Dir.glob(p)
["/tmp/d20190215-22316-ra8tss/usr/share/doc/release-notes/dummy/RELEASE-NOTES.en.txt",
"/tmp/d20190215-22316-ra8tss/usr/share/doc/release-notes/dummy/RELEASE-NOTES.de.txt"]

So the glob for the RELEASE-NOTES.{de_DE,de,en}.txt files returns "RELEASE-NOTES.en.txt", "RELEASE-NOTES.de.txt" files (in this order!). So the order of the files might be different than in the input glob, the code does not expect this and uses the first one (via .first).

Additional Problems

• The commandline tests always failed for me when running locally, however it was fine in Travis, Jenkins or OBS so I ignored that. This time I checked the details and the problem is that locally I have installed the byebug debugger. The test raises some exception and expect to print something in the exception handler. However when the debugger is installed YaST displays a popup asking to start the debugger. (In the test mode there is just dummy UI so in reality nothing is displayed in the end.)

• The firewall test failed when started via rake test:unit by passed when started via rspec ./library/network/test/firewalld_wrapper_test.rb. It turned out that when running in full test the Yast::NetworkInterfaces.List method returns some known interfaces, when running standalone the result is empty list.

[coveralls]

Coverage decreased (-0.01%) to 27.93% when pulling 4940b0c on testsuite_fix into cc403e5 on master.

[yast-bot]

✔️ Internal Jenkins job #84 successfully finished
✔️ Created IBS submit request #184764

[yast-bot]

✔️ Public Jenkins job #79 successfully finished
✔️ Created OBS submit request #676944