support reading licenses from tar archive (jsc#SLE-7214) #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code-wise LGTM, I'll test it in the patched online installer medium... |
lslezak
approved these changes
Sep 10, 2019
They are just a repackaged version of the rpm test data.
It's basically looking for a special file in the license archive. Thus it's more similar to the other fetcher methods and can profit from the cached license archive in LicensesFetchers.
|
❌ Public Jenkins job #127 failed |
|
❌ Internal Jenkins job #27 failed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Support reading licenses from a tar archive in the repository.
Plus quite some license fetcher refactoring:
#confirmation_required?fromLicensesHandlerstoLicensesFetchersSee also
This is based on @lslezak's work in
https://github.com/yast/yast-yast2/compare/new_media
Todo