Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip license fetcher #983

Merged
merged 4 commits into from Nov 21, 2019
Merged

Skip license fetcher #983

merged 4 commits into from Nov 21, 2019

Conversation

dgdavid
Copy link
Member

@dgdavid dgdavid commented Nov 20, 2019

Problem

YaST downloads the license from SCC, but then it tries to find the license on the installation medium as well. — comment#13 at bsc#1153326

Why?

Because the installer is looking for a license fetcher even when the license content was already provided, which

Note: the provided license content is used only for the default language, which was already discussed in a closed - and similar - PR for SLE-15-SP1 branch (see comments in #982).

Solution

Do not look for a license fetcher when the license content is given.

Tests

  • Unit tests updated
  • Tested by hand via driver update yupdate

Screenshots

Click to show/hide some screenshots

The error shown WITHOUT the patch

canvas


The step shown WITH the patch applied

Screenshot_openSUSE-TW_2019-11-20_12:51:38

Other relevant screenshots

The SLE-HA module selected A relevant part in the logs
Screenshot_openSUSE-TW_2019-11-20_12:51:51 Screenshot_openSUSE-TW_2019-11-20_12:51:29

Kudos to @lslezak

@coveralls
Copy link

Coverage Status

Coverage remained the same at 29.141% when pulling 716d3f1 on skip_license_fetcher into 0f84dfb on master.

@dgdavid dgdavid marked this pull request as ready for review November 20, 2019 13:06
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgdavid dgdavid merged commit 457125a into master Nov 21, 2019
@dgdavid dgdavid deleted the skip_license_fetcher branch November 21, 2019 11:51
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #145 successfully finished
✔️ Created OBS submit request #750088

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #45 successfully finished
✔️ Created IBS submit request #205860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants