New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_wsl function to detect wsl #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove Builtins call. * Add some documentation.
* master: Rename LoginDefsConfig to ShadowConfig Bump version and update changes file Log configuration conflicts Creates the login.defs.d directory if it does not exist Add a LoginDefsConfig module Extract reusable bits from LoginDefsConfig to a separate class Add a class to handle login.defs configuration files Add a CFA::LoginDefs class to handle login.defs files
teclator
reviewed
Nov 26, 2019
teclator
reviewed
Nov 26, 2019
teclator
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✔️ Public Jenkins job #151 successfully finished |
@imobachgs @lnussel thnx for the pull requests |
✔️ Internal Jenkins job #50 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased and slightly improved version of #985 (it adds some simple unit tests and drops the use of
Builtins
).The PR adds an
is_wsl
function to detect whether the system is running on WSL. See boo#1154962 for further details.