Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_wsl function to detect wsl #990

Merged
merged 6 commits into from Nov 26, 2019
Merged

Add is_wsl function to detect wsl #990

merged 6 commits into from Nov 26, 2019

Conversation

imobachgs
Copy link
Contributor

This is a rebased and slightly improved version of #985 (it adds some simple unit tests and drops the use of Builtins).

The PR adds an is_wsl function to detect whether the system is running on WSL. See boo#1154962 for further details.

lnussel and others added 6 commits November 22, 2019 16:00
* Remove Builtins call.
* Add some documentation.
* master:
  Rename LoginDefsConfig to ShadowConfig
  Bump version and update changes file
  Log configuration conflicts
  Creates the login.defs.d directory if it does not exist
  Add a LoginDefsConfig module
  Extract reusable bits from LoginDefsConfig to a separate class
  Add a class to handle login.defs configuration files
  Add a CFA::LoginDefs class to handle login.defs files
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 29.464% when pulling 21b0600 on is_wsl into 2df1aea on master.

Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit 22d3342 into master Nov 26, 2019
@imobachgs imobachgs deleted the is_wsl branch November 26, 2019 12:43
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #151 successfully finished
✔️ Created OBS submit request #751032

@teclator
Copy link
Contributor

@imobachgs @lnussel thnx for the pull requests

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #50 successfully finished
✔️ Created IBS submit request #206138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants