Add mising error handling

yasuoza · Feb 24, 2021 · 8e95bf1 · 8e95bf1
1 parent 3be4355
commit 8e95bf1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/cmd/switchbot/command/info.go b/cmd/switchbot/command/info.go
@@ -106,7 +106,10 @@ func (c *InfoCommand) parseArgs(args []string) (*infoCfg, int) {
 	flags.Usage = func() {
 		c.UI.Info(c.Help())
 	}
-	flags.Parse(args)
+
+	if err := flags.Parse(args); err != nil {
+		return cfg, 127
+	}
 
 	args = flags.Args()
 	if len(args) != 1 || (cfg.Format != "table" && cfg.Format != "json") {

diff --git a/cmd/switchbot/command/press.go b/cmd/switchbot/command/press.go
@@ -84,7 +84,10 @@ func (c *PressCommand) parseArgs(args []string) (*pressCfg, int) {
 	flags.Usage = func() {
 		c.UI.Info(c.Help())
 	}
-	flags.Parse(args)
+
+	if err := flags.Parse(args); err != nil {
+		return cfg, 127
+	}
 
 	args = flags.Args()
 	if len(args) != 1 {

diff --git a/cmd/switchbot/command/scan.go b/cmd/switchbot/command/scan.go
@@ -47,7 +47,9 @@ func (c *ScanCommand) parseArgs(args []string) (*scanCfg, int) {
 	flags.Usage = func() {
 		c.UI.Info(c.Help())
 	}
-	flags.Parse(args)
+	if err := flags.Parse(args); err != nil {
+		return cfg, 127
+	}
 	return cfg, 0
 }