Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] PiP option from popup menu's #137

Closed
bachig26 opened this issue May 23, 2022 · 5 comments
Closed

[Enhancement] PiP option from popup menu's #137

bachig26 opened this issue May 23, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@bachig26
Copy link
Contributor

From the image below, you may see the options available as in/from popup options when you press and hold the videos/contents.

This issue is to request to add an Open in PiP directly in the popup menu for easy access.

  • Mainly, I'm addressing this request from my experience as this will really help in most use case. One doesn't need to open the video page and put the video in PiP and go back to the other app. This will reduce the few steps and hassle for PiP access.

image

@arekf arekf added the enhancement New feature or request label May 24, 2022
arekf added a commit that referenced this issue May 29, 2022
@bachig26
Copy link
Contributor Author

this still doesn't work as needed, i tried just now. the video plays as minimized everytime.

@arekf
Copy link
Contributor

arekf commented May 29, 2022

I tested it on several devices and it works for me. Can you do more tests, check if player switches to AVPlayer, can you open PiP using a button?

@bachig26
Copy link
Contributor Author

I tested it on several devices and it works for me. Can you do more tests, check if player switches to AVPlayer, can you open PiP using a button?

I just reinstalled the app, it works now at everytime (I tried like ~8-10 videos) I click Play in PiP.
And also sometimes, not everytime, the video plays like a second or so at background before PiP opens. I think there is a need for for a slight delay from PiP open and video plays.

@arekf
Copy link
Contributor

arekf commented May 29, 2022

Yeah, I am aware of the unintended short play, I will fix it hopefully next release. Give me an update if you encounter more issues with opening in PiP.

@bachig26
Copy link
Contributor Author

Yeah, I am aware of the unintended short play, I will fix it hopefully next release. Give me an update if you encounter more issues with opening in PiP.

Sure. 👍

arekf added a commit that referenced this issue Jun 7, 2022
arekf added a commit that referenced this issue Jun 7, 2022
arekf added a commit that referenced this issue Jun 14, 2022
arekf added a commit that referenced this issue Jun 15, 2022
arekf added a commit that referenced this issue Jul 5, 2022
arekf added a commit that referenced this issue Jul 11, 2022
arekf added a commit that referenced this issue Aug 5, 2022
arekf added a commit that referenced this issue Aug 17, 2022
@arekf arekf closed this as completed Aug 21, 2022
arekf added a commit that referenced this issue Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants