Bugfixes (and small enhancements) #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 20, 2014 10:51
|
Great, thanks for your pull request 👍 |
yauh
added a commit
that referenced
this pull request
Feb 20, 2014
Bugfixes (and small enhancements)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grab solr task assume the downloaded file name is always
solr-{{solr_version}}. For older version of apache solr, available on https://archive.apache.org/dist/lucene/solr, the file name issolr-{{solr_version}}. The first commit adds asolr_basenamevariable which can be used to customize the basename of the downloaded file.In the startup script, the value of
SOLR_HOMEdoes not use thesolr_homevariable. The second commit fixes this.The third and fourth commit are small enhancements.