starting to address issue raised in #38 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs some kind of test with it. Integration or unit will be acceptable |
The way the library has always worked the default ssl context (when using ignore certs) would change the global context for anything in the jvm. This means ALL certs were trusted when using ignoreCert in YAVIJAVA/VIJAVA. This is a big security issue. A user on the vijava forums pointed the issue out: http://sourceforge.net/p/vijava/discussion/826592/thread/33f68590/ This fixes that issue and includes tests to verify fix. Fixes yavijava#38
michaelrice
added a commit
that referenced
this pull request
Jun 20, 2015
starting to address issue raised in #38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38