Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor metrics into objects in visualization models' metadata #71

Closed
6 tasks done
mtgraham opened this issue Apr 13, 2018 · 0 comments
Closed
6 tasks done

Refactor metrics into objects in visualization models' metadata #71

mtgraham opened this issue Apr 13, 2018 · 0 comments
Assignees
@mtgraham

Comments

@mtgraham
Copy link
Contributor

mtgraham commented Apr 13, 2018 •
edited
Loading

  • Line Chart
  • Pie Chart
  • Table
  • Metric Label
  • Goal Gauge
  • Tooltips (Not a model, but rather utilize the new metric objects to simplify tooltips)
@mtgraham mtgraham mentioned this issue Apr 13, 2018
Merged
@mtgraham mtgraham mentioned this issue Apr 16, 2018
Merged
mtgraham pushed a commit that referenced this issue Apr 17, 2018
Breaking: Refactor metrics in line-chart and pie-chart models to be o…
ced63f3 
…bjects (refs #71)
mtgraham pushed a commit that referenced this issue Apr 17, 2018
Fix: Fix tests in reports, data, and app affected by line/pie chart m…
725148e 
…etric refactor (refs #71)
mtgraham pushed a commit that referenced this issue Apr 17, 2018
Fix: Fix tests in visualizations affected by line/pie chart metric re…
012aedb 
…factor (refs #71)
mtgraham pushed a commit that referenced this issue Apr 17, 2018
Fix: Address PR Comments (refs #71)
58c4345
mtgraham pushed a commit that referenced this issue Apr 17, 2018
Fix: Address remaining PR comments (refs #71)
53f4d21
mtgraham added a commit that referenced this issue Apr 18, 2018
@mtgraham
Refactor line and pie chart visualization metric (#72)
716440c 
Breaking: Refactor metrics in line-chart and pie-chart models to be objects (refs #71)
@mtgraham mtgraham self-assigned this Apr 18, 2018
mtgraham pushed a commit that referenced this issue Apr 23, 2018
Breaking: Refactor metric label metric to be an object (refs #71)
d412ef6
@mtgraham mtgraham mentioned this issue Apr 23, 2018
Merged
mtgraham added a commit that referenced this issue Apr 24, 2018
@mtgraham
Merge pull request #82 from yahoo/refactorMetricLabelMetric
082243a 
Breaking: Refactor metric label metric to be an object (refs #71)
@mtgraham mtgraham mentioned this issue May 1, 2018
Merged
mtgraham pushed a commit that referenced this issue May 1, 2018
Breaking: Update goal gauge model metric to be an object (refs #71)
cd8e364
mtgraham added a commit that referenced this issue May 1, 2018
@mtgraham
Merge pull request #85 from yahoo/refactorGoalGaugeMetric
bfa1b6d 
Breaking: Update goal gauge model metric to be an object (refs #71)
mtgraham pushed a commit that referenced this issue May 2, 2018
Breaking: Refactor fields in table model columns to be objects (refs #71
61dada4 
)
mtgraham added a commit that referenced this issue May 2, 2018
@mtgraham
Merge pull request #73 from yahoo/refactorTableMetric
fa0a237 
Breaking: Refactor fields in table model columns to be objects (refs #71)
Xuefeng-Zhu pushed a commit that referenced this issue May 2, 2018
Merge branch 'master' into table_input
85b4d62 
* master:
  Breaking: Refactor fields in table model columns to be objects (refs #71)
  Breaking: Update goal gauge model metric to be an object (refs #71)
  New: Add number format selector component
  Fix: Add schedule button to dashboard page
  Fix: Fetch saved dashboard delivery rule
mtgraham pushed a commit that referenced this issue May 4, 2018
Breaking: Refactor tooltips to use new metric object shape in visuali…
78df993 
…zations (refs #71)
mtgraham added a commit that referenced this issue May 4, 2018
@mtgraham
Merge pull request #89 from yahoo/refactorToolTipsMetric
d24e956 
Breaking: Refactor tooltips to use new metric object shape in visualizations (refs #71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtgraham mtgraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mtgraham