Update: Initial c3 visualization extraction #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkusa
force-pushed
the
c3-package
branch
3 times, most recently
from
8f1dc03
to
0132863
Compare
cythrawll
reviewed
May 9, 2022
|
Question about the v2 serializers removal. Are we ready for this? all our viz models already v2? |
Co-authored-by: Kevin Hinterlong <kevinhinterlong@users.noreply.github.com>
@cythrawll yes, I confirmed this with @kevinhinterlong in the beginning. All tests pass, but we should do another PR to clean up any remaining v1 logic. |
cythrawll
approved these changes
May 10, 2022
kevinhinterlong
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Description
Proposed Changes
@yavin/c3packagenavi-vis-c3-charttoyavin-c3-chartnavi-vis-c3-chartScreenshots
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.