Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hash check when downloading Clang #150

Merged
merged 1 commit into from
Jun 3, 2015

Conversation

micbou
Copy link
Collaborator

@micbou micbou commented Jun 2, 2015

I made a mistake in PR #147. The SHA256 option should be set without quotes when downloading Clang. I am not sure why it was working on Travis but it did not work on my linux machine. This is certainly the cmake version.

I also removed some trailing spaces.

Sorry for the trouble.

CLA already signed.

@icholy
Copy link
Contributor

icholy commented Jun 3, 2015

I'm encountering this error as well:

  RAN: '/usr/bin/cmake -G Unix Makefiles -DUSE_CLANG_COMPLETER=ON -DUSE_DEV_FLAGS=ON /home/icholy/Code/src/github.com/icholy/ycmd/cpp'

  STDOUT:


  STDERR:
Your C++ compiler supports C++11, compiling in that mode.
Downloading Clang 3.6
CMake Error at ycm/CMakeLists.txt:87 (file):
  file DOWNLOAD HASH mismatch

    for file: [/home/icholy/Code/src/github.com/icholy/ycmd/cpp/../clang_archives/clang+llvm-3.6.0-x86_64-linux-gnu-ubuntu-14.04.tar.xz]
      expected hash: ["e8396103fbf794e6af671593659458dfe841c32234d3cd4f37be0b48cd6a9f8b"]
        actual hash: [e8396103fbf794e6af671593659458dfe841c32234d3cd4f37be0b48cd6a9f8b]

@icholy icholy mentioned this pull request Jun 3, 2015
@micbou
Copy link
Collaborator Author

micbou commented Jun 3, 2015

Yes, the quotes should not be in the expected hash. This PR fixes this.

Valloric added a commit that referenced this pull request Jun 3, 2015
Fix hash check when downloading Clang
@Valloric Valloric merged commit d34c4b8 into ycm-core:master Jun 3, 2015
@Valloric
Copy link
Member

Valloric commented Jun 3, 2015

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants