[READY] Fixing tests for go v1.22.0 #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1735 +/- ##
=======================================
Coverage 95.44% 95.44%
=======================================
Files 83 83
Lines 8166 8166
Branches 163 163
=======================================
Hits 7794 7794
Misses 322 322
Partials 50 50 |
bstaletic
force-pushed
the
new_go_fix
branch
from
39d38b4
to
492a771
Compare
Latest go version changes how detailed info looks, so we need to change the tests. Opted for matching with a regex, so the test can work with older versions of go as well.
puremourning
approved these changes
Feb 14, 2024
puremourning
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)
|
Thanks for sending a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest go version changes how diagnostics look, so we need to change the tests. Opted for matching with a regex, so the test can work with older versions of go as well.
This change is