Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added feature returnValue for saveWorkbokk #71 #93

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

ycphs
Copy link
Owner

@ycphs ycphs commented Aug 17, 2020

I added a new feature to the function.

It would be great, if you (@rmanfredi) could check. Is that what you had in mind?

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #93 into master will increase coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   58.72%   59.23%   +0.50%     
==========================================
  Files          30       30              
  Lines        8696     8630      -66     
==========================================
+ Hits         5107     5112       +5     
+ Misses       3589     3518      -71     
Impacted Files Coverage Δ
R/wrappers.R 46.64% <ø> (+0.18%) ⬆️
R/conditional_formatting.R 0.00% <0.00%> (ø)
R/WorkbookClass.R 50.99% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ec5dd0...c320351. Read the comment docs.

@ycphs ycphs merged commit 1173d8e into master Sep 14, 2020
@ycphs ycphs deleted the returnValueSaveWorkbook branch September 21, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant