fix: timeseries gap comparison failing with no gaps for date index #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquemy
approved these changes
Feb 21, 2024
aquemy
pushed a commit
that referenced
this pull request
Feb 26, 2024
…1551) * fix: ts gap comparison failing with no gaps * fix(linting): code formatting --------- Co-authored-by: Azory YData Bot <azory@ydata.ai>
fabclmnt
added a commit
that referenced
this pull request
Apr 5, 2024
* chore(actions): update actions/cache action to v4 * fix: comparison to_json pd.Series encoding error (#1538) * fix: comparison to_json pd.Series encoding error * fix(linting): code formatting * fix: unit test * fix(linting): code formatting --------- Co-authored-by: Azory YData Bot <azory@ydata.ai> * closes #1504 - switch create_expectation_suite with add_expectation_suite (#1540) * fix: timeseries gap comparison failing with no gaps for date index (#1551) * fix: ts gap comparison failing with no gaps * fix(linting): code formatting --------- Co-authored-by: Azory YData Bot <azory@ydata.ai> * chore: readme * docs: update docs readme. --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Barros <alexbarros@users.noreply.github.com> Co-authored-by: Azory YData Bot <azory@ydata.ai> Co-authored-by: Nadav Shatz <nadav@tailorbrands.com> Co-authored-by: Fabiana Clemente <fabianaclemente@Fabianas-MacBook-Air.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating gap statistics for date indexes, when there were no gaps the gap_stats.min() returned a NaT which lead to failures while trying to render it.
Also fixed a small error on time series statistics overview tab