Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryClient API #1003

Merged
merged 5 commits into from
Feb 28, 2024
Merged

QueryClient API #1003

merged 5 commits into from
Feb 28, 2024

Conversation

asmyasnikov
Copy link
Member

@asmyasnikov asmyasnikov commented Jan 16, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #983

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added the enhancement New feature or request label Jan 16, 2024
@asmyasnikov asmyasnikov self-assigned this Jan 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: Patch coverage is 75.61235% with 229 lines in your changes are missing coverage. Please review.

Project coverage is 66.60%. Comparing base (f838b39) to head (ef1b438).

Files Patch % Lines
query/execute_options.go 50.74% 33 Missing ⚠️
query/transaction_settings.go 30.43% 32 Missing ⚠️
internal/query/client.go 81.97% 21 Missing and 10 partials ⚠️
query/transaction_control.go 66.66% 23 Missing ⚠️
internal/allocator/allocator.go 83.65% 15 Missing and 2 partials ⚠️
query/session_status.go 0.00% 14 Missing ⚠️
internal/query/config/options.go 42.85% 12 Missing ⚠️
internal/query/result.go 92.03% 8 Missing and 1 partial ⚠️
internal/query/config/config.go 68.00% 8 Missing ⚠️
internal/query/pool.go 75.00% 6 Missing and 2 partials ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
+ Coverage   66.38%   66.60%   +0.22%     
==========================================
  Files         260      283      +23     
  Lines       26640    27579     +939     
==========================================
+ Hits        17684    18370     +686     
- Misses       8117     8347     +230     
- Partials      839      862      +23     
Flag Coverage Δ
54.51% <54.31%> (-0.11%) ⬇️
go-1.21.x 68.52% <75.61%> (+0.19%) ⬆️
go-1.22.x 66.56% <75.61%> (+0.28%) ⬆️
integration 54.51% <54.31%> (-0.11%) ⬇️
macOS 37.74% <55.69%> (+0.63%) ⬆️
ubuntu 37.75% <55.69%> (+0.69%) ⬆️
unit 37.80% <55.69%> (+0.64%) ⬆️
windows 37.78% <55.69%> (+0.65%) ⬆️
ydb-22.5 52.45% <8.73%> (-1.78%) ⬇️
ydb-23.1 52.51% <8.73%> (-1.53%) ⬇️
ydb-23.2 52.42% <8.73%> (-1.62%) ⬇️
ydb-23.3 52.59% <8.73%> (-1.74%) ⬇️
ydb-24.1 54.35% <54.31%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 16, 2024

github.com/ydb-platform/ydb-go-sdk/v3

incompatible changes

Connection.Query: added

compatible changes

(*Driver).Query: added
WithQueryConfigOption: added

github.com/ydb-platform/ydb-go-sdk/v3/query

compatible changes

package added

github.com/ydb-platform/ydb-go-sdk/v3/trace

compatible changes

Query: added

summary

Base version: v3.57.0-rc2.0.20240228093723-f838b39587a5 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.57.0-rc2.

@asmyasnikov asmyasnikov force-pushed the query-client-interface branch 4 times, most recently from 45c2d7d to 27df322 Compare January 18, 2024 10:05
@asmyasnikov asmyasnikov force-pushed the query-client-interface branch 3 times, most recently from 5927bbf to bc65e89 Compare February 19, 2024 08:51
@asmyasnikov asmyasnikov changed the base branch from query to master February 19, 2024 08:57
@asmyasnikov asmyasnikov force-pushed the query-client-interface branch 3 times, most recently from 5b1c19f to 26c30c9 Compare February 19, 2024 17:33
Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

🌋 Here are results of SLO test for Go SDK native:

Grafana Dashboard

SLO-native

Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-databasesql

@asmyasnikov asmyasnikov merged commit 72c8364 into master Feb 28, 2024
44 checks passed
@asmyasnikov asmyasnikov deleted the query-client-interface branch February 28, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants