Fix lost coordinator steps during mediator reconnect race #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚪
|
|
⚪
|
CyberROFL
approved these changes
Feb 16, 2024
This was referenced Feb 17, 2024
snaury
added a commit
to snaury/ydb
that referenced
this pull request
Feb 19, 2024
snaury
added a commit
that referenced
this pull request
Feb 19, 2024
This was referenced Feb 20, 2024
Closed
This was referenced Feb 28, 2024
Closed
This was referenced Jun 7, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
Fix lost coordinator steps during mediator reconnect race.
Changelog category
Additional information
Coordinator's mediator queues were changed in 24-1 to support efficient planning of volatile transactions. Unfortunately mediator queue actor didn't handle mediator steps during mediator reconnect (never needed to, since old code was reloading the full queue from disk on every reconnect), and in rare failure modes this could cause entire planned steps to be lost at some mediators. The fix is to handle mediator steps during re-sync. Fixes KIKIMR-21077.