Support sequences backup with current value #3089

shnikd · 2024-03-22T12:56:56Z

No description provided.

github-actions · 2024-03-22T13:00:29Z

⚪ 2024-03-22 13:00:29 UTC Pre-commit check for 1ea186f has started.
⚪ 2024-03-22 13:00:30 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-03-22 13:34:55 UTC Build successful.

github-actions · 2024-03-22T13:08:51Z

⚪ 2024-03-22 13:08:50 UTC Pre-commit check for 1ea186f has started.
⚪ 2024-03-22 13:08:52 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-22 13:45:56 UTC Build successful.
⚪ 2024-03-22 13:46:24 UTC Tests are running...
🔴 2024-03-22 15:42:54 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
69021	57912	0	8	11023	78

github-actions · 2024-03-22T13:14:51Z

⚪ 2024-03-22 13:14:51 UTC Pre-commit check for 1ea186f has started.
⚪ 2024-03-22 13:14:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-22 13:52:53 UTC Build successful.
⚪ 2024-03-22 13:53:07 UTC Tests are running...
🔴 2024-03-22 16:01:20 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15149	14500	0	79	536	34

ydb/core/tx/schemeshard/schemeshard__operation_copy_sequence.cpp

ydb/core/tx/schemeshard/ut_helpers/ya.make

ydb/core/tx/schemeshard/ut_helpers/helpers.cpp

ydb/core/tx/schemeshard/schemeshard_export_flow_proposals.cpp

ydb/core/tx/schemeshard/schemeshard__operation_copy_sequence.cpp

github-actions · 2024-03-25T08:17:06Z

⚪ 2024-03-25 08:17:06 UTC Pre-commit check for ab34b07 has started.
⚪ 2024-03-25 08:17:08 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-25 08:57:19 UTC Build successful.
⚪ 2024-03-25 08:57:34 UTC Tests are running...
🔴 2024-03-25 09:43:20 UTC Test run completed, no test results found for commit bc90b90. Please check build logs.
⚫ 2024-03-25 09:43:23 UTC Check cancelled

github-actions · 2024-03-25T08:17:10Z

⚪ 2024-03-25 08:17:10 UTC Pre-commit check for ab34b07 has started.
⚪ 2024-03-25 08:17:13 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-03-25 08:55:21 UTC Build successful.

github-actions · 2024-03-25T08:19:22Z

⚪ 2024-03-25 08:19:22 UTC Pre-commit check for ab34b07 has started.
⚪ 2024-03-25 08:19:24 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-25 08:57:57 UTC Build successful.
⚪ 2024-03-25 08:58:14 UTC Tests are running...
🔴 2024-03-25 09:43:19 UTC Test run completed, no test results found for commit bc90b90. Please check build logs.
⚫ 2024-03-25 09:43:23 UTC Check cancelled

github-actions · 2024-03-25T09:44:38Z

⚪ 2024-03-25 09:44:38 UTC Pre-commit check for f90c9a3 has started.
⚪ 2024-03-25 09:44:39 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-25 09:47:46 UTC Build successful.
⚪ 2024-03-25 09:47:57 UTC Tests are running...
🔴 2024-03-25 10:37:18 UTC Test run completed, no test results found for commit 82d5b85. Please check build logs.
⚫ 2024-03-25 10:37:21 UTC Check cancelled

github-actions · 2024-03-25T09:44:38Z

⚪ 2024-03-25 09:44:38 UTC Pre-commit check for f90c9a3 has started.
⚪ 2024-03-25 09:44:40 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-25 09:47:19 UTC Build successful.
⚪ 2024-03-25 09:47:33 UTC Tests are running...
🔴 2024-03-25 10:37:18 UTC Test run completed, no test results found for commit 82d5b85. Please check build logs.
⚫ 2024-03-25 10:37:21 UTC Check cancelled

github-actions · 2024-03-25T09:46:47Z

⚪ 2024-03-25 09:46:46 UTC Pre-commit check for f90c9a3 has started.
⚪ 2024-03-25 09:46:49 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-03-25 09:50:16 UTC Build successful.

github-actions · 2024-03-25T10:39:14Z

⚪ 2024-03-25 10:39:14 UTC Pre-commit check for 0de43f2 has started.
⚪ 2024-03-25 10:39:20 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-25 10:41:50 UTC Build successful.
⚪ 2024-03-25 10:42:05 UTC Tests are running...
🔴 2024-03-25 11:29:55 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14413	14124	0	42	220	27

github-actions · 2024-03-25T10:39:28Z

⚪ 2024-03-25 10:39:28 UTC Pre-commit check for 0de43f2 has started.
⚪ 2024-03-25 10:39:30 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-03-25 10:41:44 UTC Build successful.

github-actions · 2024-03-25T10:41:04Z

⚪ 2024-03-25 10:41:04 UTC Pre-commit check for 0de43f2 has started.
⚪ 2024-03-25 10:41:06 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-25 10:43:28 UTC Build successful.
⚪ 2024-03-25 10:43:42 UTC Tests are running...
🔴 2024-03-25 11:40:49 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
69044	57931	0	9	11031	73

ydb/core/protos/tx_sequenceshard.proto

ydb/public/api/protos/ydb_table.proto

ydb/core/protos/flat_scheme_op.proto

ydb/core/protos/tx_sequenceshard.proto

ydb/core/tx/schemeshard/schemeshard__operation_copy_sequence.cpp

github-actions · 2024-03-26T12:27:56Z

⚪ 2024-03-26 12:27:55 UTC Pre-commit check for 1706b70 has started.
⚪ 2024-03-26 12:27:57 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-03-26 13:04:12 UTC Build failed. see the build logs.

github-actions · 2024-03-26T12:28:03Z

⚪ 2024-03-26 12:28:03 UTC Pre-commit check for 1706b70 has started.
⚪ 2024-03-26 12:28:05 UTC Build linux-x86_64-release-asan is running...
🔴 2024-03-26 13:07:52 UTC Build failed. see the build logs.
🔴 2024-03-26 13:07:53 UTC Tests run skipped.

github-actions · 2024-03-26T12:28:26Z

⚪ 2024-03-26 12:28:26 UTC Pre-commit check for 1706b70 has started.
⚪ 2024-03-26 12:28:29 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-03-26 13:08:56 UTC Build failed. see the build logs.
🔴 2024-03-26 13:08:58 UTC Tests run skipped.

github-actions · 2024-03-26T14:00:27Z

⚪ 2024-03-26 14:00:26 UTC Pre-commit check for f28e33e has started.
⚪ 2024-03-26 14:00:28 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-03-26 14:02:11 UTC Build successful.

github-actions · 2024-03-26T14:01:08Z

⚪ 2024-03-26 14:01:08 UTC Pre-commit check for f28e33e has started.
⚪ 2024-03-26 14:01:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-26 14:03:16 UTC Build successful.
⚪ 2024-03-26 14:05:10 UTC Tests are running...
🔴 2024-03-26 15:56:27 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
69048	57944	0	4	11031	69

github-actions · 2024-03-26T14:01:10Z

⚪ 2024-03-26 14:01:10 UTC Pre-commit check for f28e33e has started.
⚪ 2024-03-26 14:01:13 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-26 14:03:08 UTC Build successful.
⚪ 2024-03-26 14:03:29 UTC Tests are running...
🔴 2024-03-26 15:36:34 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14419	14201	0	36	155	27

github-actions · 2024-03-27T01:01:49Z

⚪ 2024-03-27 01:01:49 UTC Pre-commit check for f19d584 has started.
⚪ 2024-03-27 01:01:52 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-03-27 01:10:07 UTC Check cancelled

github-actions · 2024-03-27T01:01:59Z

⚪ 2024-03-27 01:01:59 UTC Pre-commit check for f19d584 has started.
⚪ 2024-03-27 01:02:01 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-03-27 01:10:06 UTC Check cancelled

github-actions · 2024-03-27T01:04:22Z

⚪ 2024-03-27 01:04:21 UTC Pre-commit check for f19d584 has started.
⚪ 2024-03-27 01:04:24 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-03-27 01:10:07 UTC Check cancelled

github-actions · 2024-03-27T01:11:15Z

⚪ 2024-03-27 01:11:15 UTC Pre-commit check for f996da0 has started.
⚪ 2024-03-27 01:11:16 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-27 01:21:34 UTC Build successful.
⚪ 2024-03-27 01:23:34 UTC Tests are running...
🔴 2024-03-27 03:00:53 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14076	13784	0	52	212	28

github-actions · 2024-03-27T01:11:15Z

⚪ 2024-03-27 01:11:15 UTC Pre-commit check for f996da0 has started.
⚪ 2024-03-27 01:11:16 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-27 01:24:09 UTC Build successful.
⚪ 2024-03-27 01:26:04 UTC Tests are running...
🔴 2024-03-27 03:12:22 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68741	57614	0	9	11050	68

github-actions · 2024-03-27T01:13:34Z

⚪ 2024-03-27 01:13:34 UTC Pre-commit check for f996da0 has started.
⚪ 2024-03-27 01:13:38 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-03-27 01:23:27 UTC Build successful.

snaury

Думаю LGTM. Из совсем мелкого меня смущает, что ReturnSetVal будет возвращать не текущее значение sequence'а, а какое-то там старое, которое делали во время его создания, но это не публичное апи и потому не важно. В будущем кому-нибудь нужно будет сделать возможно получения правильного текущего set_val в публичном апи, чтобы правильно бекапить таблицы с sequence'ами можно было не только на сервере, но и локально в файлики, но точно не в этом pr.

Fixes

9ae9dab

shnikd requested a review from ijon March 22, 2024 12:57

shnikd requested review from snaury and gridnevvvit March 22, 2024 13:05

snaury reviewed Mar 22, 2024

View reviewed changes

ydb/core/tx/schemeshard/schemeshard__operation_copy_sequence.cpp Outdated Show resolved Hide resolved

ijon requested changes Mar 22, 2024

View reviewed changes

snaury reviewed Mar 22, 2024

View reviewed changes

ydb/core/tx/schemeshard/schemeshard__operation_copy_sequence.cpp Outdated Show resolved Hide resolved

shnikd added 2 commits March 22, 2024 20:29

Fixes

da7e50a

Fixes

bc90b90

Fixes

82d5b85

shnikd requested a review from ijon March 25, 2024 09:48

Fixes

4bfdd14

snaury reviewed Mar 25, 2024

View reviewed changes

shnikd added 2 commits March 26, 2024 15:21

Fixes

111632b

Fixes

1ed48a8

Fixes

46e1e9c

Fixes

a74befa

Fixes

aea5bd0

snaury reviewed Mar 28, 2024

View reviewed changes

ijon approved these changes Mar 29, 2024

View reviewed changes

shnikd merged commit 3212f32 into ydb-platform:main Mar 29, 2024
3 of 5 checks passed

shnikd linked an issue Mar 29, 2024 that may be closed by this pull request

support backup of the sequences #1965

Closed

serbel324 mentioned this pull request Apr 2, 2024

Add tracing to load actor #3395

Merged

This was referenced Apr 4, 2024

hotkeys crush on describe #3462

Merged

added QuotaStorage to tenantinfo response #3463

Merged

query stats full #3464

Merged

shnikd mentioned this pull request Apr 4, 2024

Support create sequence in pg parser #3465

Merged

StekPerepolnen mentioned this pull request Apr 4, 2024

hc api: updated possible problems #3482

Open

This was referenced Apr 6, 2024

Fix kafka read session verify #3522

Merged

Fix kafka read session partitions releases #3528

Merged

StekPerepolnen mentioned this pull request Apr 10, 2024

hc fallback when static group has unknown status #3620

Merged

shnikd mentioned this pull request Apr 11, 2024

Support create sequence #3662

Merged

This was referenced Apr 16, 2024

json_autocomplete error reports #3784

Merged

json_storage added pdiskid filter #4037

Merged

serbel324 mentioned this pull request Apr 25, 2024

Introduce local SyncLog data cutter #4124

Merged

shnikd added a commit to shnikd/ydb that referenced this pull request May 30, 2024

Support sequences backup with current value (ydb-platform#3089)

5b1f592

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support sequences backup with current value #3089

Support sequences backup with current value #3089

shnikd commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

snaury left a comment

Support sequences backup with current value #3089

Support sequences backup with current value #3089

Conversation

shnikd commented Mar 22, 2024 • edited Loading

github-actions bot commented Mar 22, 2024 • edited Loading

github-actions bot commented Mar 22, 2024 • edited Loading

github-actions bot commented Mar 22, 2024 • edited Loading

github-actions bot commented Mar 25, 2024 • edited Loading

github-actions bot commented Mar 25, 2024 • edited Loading

github-actions bot commented Mar 25, 2024 • edited Loading

github-actions bot commented Mar 25, 2024 • edited Loading

github-actions bot commented Mar 25, 2024 • edited Loading

github-actions bot commented Mar 25, 2024 • edited Loading

github-actions bot commented Mar 25, 2024 • edited Loading

github-actions bot commented Mar 25, 2024 • edited Loading

github-actions bot commented Mar 25, 2024 • edited Loading

github-actions bot commented Mar 26, 2024 • edited Loading

github-actions bot commented Mar 26, 2024 • edited Loading

github-actions bot commented Mar 26, 2024 • edited Loading

github-actions bot commented Mar 26, 2024 • edited Loading

github-actions bot commented Mar 26, 2024 • edited Loading

github-actions bot commented Mar 26, 2024 • edited Loading

github-actions bot commented Mar 27, 2024 • edited Loading

github-actions bot commented Mar 27, 2024 • edited Loading

github-actions bot commented Mar 27, 2024 • edited Loading

github-actions bot commented Mar 27, 2024 • edited Loading

github-actions bot commented Mar 27, 2024 • edited Loading

github-actions bot commented Mar 27, 2024 • edited Loading

snaury left a comment

Choose a reason for hiding this comment

shnikd commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading