-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YQ-3116 Add restoring issues to query status #3977
YQ-3116 Add restoring issues to query status #3977
Conversation
⚪
|
⚪
|
@@ -286,7 +286,8 @@ void TCheckpointCoordinator::Handle(const NYql::NDq::TEvDqCompute::TEvRestoreFro | |||
const TString& statusName = NYql::NDqProto::TEvRestoreFromCheckpointResult_ERestoreStatus_Name(status); | |||
CC_LOG_D("[" << checkpoint << "] Got TEvRestoreFromCheckpointResult; taskId: "<< record.GetTaskId() | |||
<< ", checkpoint: " << checkpoint | |||
<< ", status: " << statusName); | |||
<< ", status: " << statusName | |||
<< ", issues: " << record.GetIssues()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not good in common to have multiline string with issues in log. There is special logging method in TIssues, that is better to use here: https://github.com/ydb-platform/ydb/blob/main/ydb/library/yql/public/issue/yql_issue.h#L320
@@ -301,9 +302,10 @@ void TCheckpointCoordinator::Handle(const NYql::NDq::TEvDqCompute::TEvRestoreFro | |||
} | |||
|
|||
if (status != NYql::NDqProto::TEvRestoreFromCheckpointResult_ERestoreStatus_OK) { | |||
CC_LOG_E("[" << checkpoint << "] Can't restore: " << statusName); | |||
auto msg = TStringBuilder() << "Can't restore: " << statusName << ", " << record.GetIssues(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not good in common to have multiline string with issues in log. There is special logging method in TIssues, that is better to use here: https://github.com/ydb-platform/ydb/blob/main/ydb/library/yql/public/issue/yql_issue.h#L320
But these issues should be subissues in checkpoint coordinator error message and TEvDqFailure
⚪ |
⚪ |
⚪
|
⚪
|
⚪
|
⚪
|
Changelog entry
...
Changelog category
Additional information
...