YQ-3116 Add restoring issues to query status #3977
Conversation
|
⚪
|
|
⚪
|
| @@ -286,7 +286,8 @@ void TCheckpointCoordinator::Handle(const NYql::NDq::TEvDqCompute::TEvRestoreFro | |||
| const TString& statusName = NYql::NDqProto::TEvRestoreFromCheckpointResult_ERestoreStatus_Name(status); | |||
| CC_LOG_D("[" << checkpoint << "] Got TEvRestoreFromCheckpointResult; taskId: "<< record.GetTaskId() | |||
| << ", checkpoint: " << checkpoint | |||
| << ", status: " << statusName); | |||
| << ", status: " << statusName | |||
| << ", issues: " << record.GetIssues()); | |||
There was a problem hiding this comment.
It is not good in common to have multiline string with issues in log. There is special logging method in TIssues, that is better to use here: https://github.com/ydb-platform/ydb/blob/main/ydb/library/yql/public/issue/yql_issue.h#L320
| @@ -301,9 +302,10 @@ void TCheckpointCoordinator::Handle(const NYql::NDq::TEvDqCompute::TEvRestoreFro | |||
| } | |||
|
|
|||
| if (status != NYql::NDqProto::TEvRestoreFromCheckpointResult_ERestoreStatus_OK) { | |||
| CC_LOG_E("[" << checkpoint << "] Can't restore: " << statusName); | |||
| auto msg = TStringBuilder() << "Can't restore: " << statusName << ", " << record.GetIssues(); | |||
There was a problem hiding this comment.
It is not good in common to have multiline string with issues in log. There is special logging method in TIssues, that is better to use here: https://github.com/ydb-platform/ydb/blob/main/ydb/library/yql/public/issue/yql_issue.h#L320
But these issues should be subissues in checkpoint coordinator error message and TEvDqFailure
|
⚪ |
|
⚪ |
|
⚪
|
|
⚪
|
|
⚪
|
|
⚪
|
Changelog entry
...
Changelog category
Additional information
...