Reimplement IFunctionTypeInfoBuilder15 via NVI #4405
Conversation
|
⚪
|
|
⚪
|
| @@ -646,8 +646,8 @@ class IFunctionTypeInfoBuilder14: public IFunctionTypeInfoBuilder13 { | |||
| #if UDF_ABI_COMPATIBILITY_VERSION_CURRENT >= UDF_ABI_COMPATIBILITY_VERSION(2, 28) | |||
| class IFunctionTypeInfoBuilder15: public IFunctionTypeInfoBuilder14 { | |||
| public: | |||
| virtual IFunctionTypeInfoBuilder15& SupportsBlocks() = 0; | |||
| virtual IFunctionTypeInfoBuilder15& IsStrict() = 0; | |||
| virtual IFunctionTypeInfoBuilder15& SupportsBlocksImpl(void) = 0; | |||
| @@ -709,6 +709,18 @@ class IFunctionTypeInfoBuilder: public IFunctionTypeInfoBuilderImpl { | |||
| return *this; | |||
| } | |||
|
|
|||
| #if UDF_ABI_COMPATIBILITY_VERSION_CURRENT >= UDF_ABI_COMPATIBILITY_VERSION(2, 28) | |||
| IFunctionTypeInfoBuilder& SupportsBlocks(void) { | |||
| SupportsBlocksImpl(); | |||
There was a problem hiding this comment.
Тогда уж return SupportsBlocksImpl();
There was a problem hiding this comment.
Discussed offline: decided to left intact to be in sync with the surrounding sources.
All the interfaces provided by IFunctionTypeInfoBuilder15 has no non-virtual wrappers in the public interface IFunctionTypeInfoBuilder, and yield the instance of the particular version of the interface. This might break the chain of hints for function type builder. This patch reimplements IFunctionTypeInfoBuilder15 via NVI pattern following the way all previous versions of this interface are written.
To ensure everything works fine as a result of the previous patch, the hints used to create simple Arrow UDFs with optional arguments are reordered in the right way.
igormunkin
force-pushed
the
imun/fix-nvi-for-IFunctionTypeInfoBuilder15
branch
from
5bd7fff
to
a2b08e0
Compare
|
⚪
|
|
⚪
|
All the interfaces provided by
IFunctionTypeInfoBuilder15has no non-virtual wrappers in the public interfaceIFunctionTypeInfoBuilder, and yield the instance of the particular version of the interface. This might break the chain of hints for function type builder.This patch reimplements
IFunctionTypeInfoBuilder15via NVI pattern following the way all previous versions of this interface are written.To ensure everything works fine as a result of the previous patch, the hints used to create simple Arrow UDFs with optional arguments are reordered in the right way.
Changelog category