-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oidc proxy AuthorizationServer redirect on wrong state #4641
oidc proxy AuthorizationServer redirect on wrong state #4641
Conversation
⚪
|
⚪
|
7fe147d
to
6397c1b
Compare
6397c1b
to
add8c90
Compare
⚪
|
⚪
|
add8c90
to
e57c9f0
Compare
⚪
|
⚪
|
c98ebb9
to
b7611cf
Compare
⚪
|
⚪
|
@@ -142,7 +142,7 @@ class THandlerSessionCreate : public NActors::TActorBootstrapped<THandlerSession | |||
NHttp::THeaders headers(Request->Headers); | |||
NHttp::TCookies cookies(headers.Get("cookie")); | |||
|
|||
if (!code.Empty() && IsStateValid(state, cookies, ctx)) { | |||
if (IsStateValid(state, cookies, ctx) && !code.Empty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you switch the conditions?
If parameter "code" is empty then it doesn't make sense to check parameter "state"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that in the IsStateValid method, the IsAjaxRequest variable is initialized, which can affect the response code.
b7611cf
to
bbbca8d
Compare
⚪
|
⚪
|
bbbca8d
to
9ffee8b
Compare
⚪
|
⚪
|
Changelog entry
4595
Changelog category