Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log space color limits, #4550 #4554

Merged
merged 2 commits into from
May 15, 2024

Conversation

the-ancient-1
Copy link
Member

@the-ancient-1 the-ancient-1 commented May 15, 2024

Changelog entry

PDisk should raise yellow move flag at 120 busy log chunks and yellow stop flag at 130 busy log chunks.

Changelog category

  • Bugfix

Additional information

PDisk log space flags were ignored by VDisk and were raised at incorrect thresholds. Now that VDisks use theese flags, thresholds should be fixed. This commit fixes the thresholds so that pdisk does not raise the yellow_stop flag at 20 busy chunks.

Copy link

github-actions bot commented May 15, 2024

2024-05-15 12:57:49 UTC Pre-commit check for fa45c39 has started.
2024-05-15 12:57:52 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-15 12:59:42 UTC Build successful.

Copy link

github-actions bot commented May 15, 2024

2024-05-15 12:57:49 UTC Pre-commit check for fa45c39 has started.
2024-05-15 12:57:52 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-15 12:59:51 UTC Build successful.
2024-05-15 13:01:40 UTC Tests are running...
🔴 2024-05-15 14:17:59 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13694 12373 0 14 1297 10

Copy link

github-actions bot commented May 15, 2024

2024-05-15 12:58:04 UTC Pre-commit check for fa45c39 has started.
2024-05-15 12:58:06 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-15 13:00:10 UTC Build successful.
2024-05-15 13:01:54 UTC Tests are running...
🔴 2024-05-15 14:40:28 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9581 9537 0 11 21 12

alexvru
alexvru previously approved these changes May 15, 2024
@the-ancient-1 the-ancient-1 linked an issue May 15, 2024 that may be closed by this pull request
Copy link

github-actions bot commented May 15, 2024

2024-05-15 19:31:10 UTC Pre-commit check for 848a8fe has started.
2024-05-15 19:31:13 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-15 19:33:08 UTC Build successful.

Copy link

github-actions bot commented May 15, 2024

2024-05-15 19:31:19 UTC Pre-commit check for 848a8fe has started.
2024-05-15 19:31:22 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-15 19:33:33 UTC Build successful.
2024-05-15 19:35:34 UTC Tests are running...
🔴 2024-05-15 21:20:16 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9890 9842 0 18 20 10

Copy link

github-actions bot commented May 15, 2024

2024-05-15 19:31:20 UTC Pre-commit check for 848a8fe has started.
2024-05-15 19:31:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-15 19:33:28 UTC Build successful.
2024-05-15 19:35:34 UTC Tests are running...
🔴 2024-05-15 20:52:44 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14003 12695 0 3 1297 8

@the-ancient-1 the-ancient-1 merged commit 01efbd3 into ydb-platform:main May 15, 2024
3 of 5 checks passed
@the-ancient-1 the-ancient-1 deleted the fix_pdisk_log_colors branch May 15, 2024 19:53
naspirato pushed a commit to naspirato/ydb that referenced this pull request May 15, 2024
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix PDisk log space colors
3 participants