hive metastore client has been added #4593

dorooleg · 2024-05-16T09:58:53Z

Changelog entry

hive metastore client has been added

Changelog category

Not for changelog (changelog entry is not required)

Additional information

...

github-actions · 2024-05-16T10:38:10Z

⚪ 2024-05-16 10:38:09 UTC Pre-commit check for eb56ca0 has started.
⚪ 2024-05-16 10:38:13 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-16 10:40:55 UTC Build failed. see the build logs.
🔴 2024-05-16 10:42:24 UTC Tests run skipped.

github-actions · 2024-05-16T11:52:30Z

⚪ 2024-05-16 11:52:30 UTC Pre-commit check for eb56ca0 has started.
⚪ 2024-05-16 11:52:31 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-16 11:54:58 UTC Build failed. see the build logs.

github-actions · 2024-05-16T11:55:46Z

⚪ 2024-05-16 11:55:45 UTC Pre-commit check for eb56ca0 has started.
⚪ 2024-05-16 11:55:47 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-16 11:57:34 UTC Build failed. see the build logs.
🔴 2024-05-16 11:58:46 UTC Tests run skipped.

github-actions · 2024-05-16T22:46:24Z

⚪ 2024-05-16 22:46:24 UTC Pre-commit check for 8b1c409 has started.
⚪ 2024-05-16 22:46:26 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-16 22:48:40 UTC Build successful.

github-actions · 2024-05-16T22:46:35Z

⚪ 2024-05-16 22:46:35 UTC Pre-commit check for 8b1c409 has started.
⚪ 2024-05-16 22:46:37 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-16 22:48:48 UTC Build successful.
⚫ 2024-05-16 22:49:00 UTC Check cancelled

github-actions · 2024-05-16T22:46:38Z

⚪ 2024-05-16 22:46:38 UTC Pre-commit check for 8b1c409 has started.
⚪ 2024-05-16 22:46:41 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-05-16 22:49:10 UTC Check cancelled

github-actions · 2024-05-16T22:48:06Z

✅ Documentation build

Revision built successfully
Revision preview link

github-actions · 2024-05-16T22:50:17Z

⚪ 2024-05-16 22:50:16 UTC Pre-commit check for 06b5357 has started.
⚪ 2024-05-16 22:50:18 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-16 22:52:45 UTC Build successful.
⚪ 2024-05-16 22:54:20 UTC Tests are running...
🟢 2024-05-16 22:56:25 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1	1	0	0	0	0

github-actions · 2024-05-16T22:50:27Z

⚪ 2024-05-16 22:50:27 UTC Pre-commit check for 06b5357 has started.
⚪ 2024-05-16 22:50:28 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-16 22:51:27 UTC Build successful.

github-actions · 2024-05-16T22:52:37Z

⚪ 2024-05-16 22:52:36 UTC Pre-commit check for 06b5357 has started.
⚪ 2024-05-16 22:52:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-16 22:53:56 UTC Build successful.
⚪ 2024-05-16 22:55:36 UTC Tests are running...
🟢 2024-05-16 22:57:19 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1	1	0	0	0	0

uzhastik · 2024-05-17T10:35:42Z

что за файлы в gen-cpp? как их получать? можно ли руками редактировать?

uzhastik · 2024-05-17T10:36:59Z

ydb/core/external_sources/hive_metastore/ya.make

+LIBRARY()
+
+SRCS(
+    # thrift -r --gen cpp hive_metastore.thrift


положи это лучше в readme и укажи точную строчку для генерации, такая явно не взлетит. и должно быть понятно в какой директории запускать.

добавил readme

uzhastik · 2024-05-17T10:37:37Z

ydb/core/external_sources/hive_metastore/ya.make

+    gen-cpp/hive_metastore_types.cpp
+
+    # hive metastore external data source
+    hive_metastore_client.cpp


давай сторонний код положим в одну либу, а наш - в другую

Сделать еще одну поддиректорию hive_metastore_native и туда запихнуть gen-cpp share *.thrift и прописать ее как LIBRARY ?

да, так норм

github-actions · 2024-05-17T12:37:01Z

⚪ 2024-05-17 12:37:01 UTC Pre-commit check for a30088c has started.
⚪ 2024-05-17 12:37:03 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-17 12:41:25 UTC Build successful.

github-actions · 2024-05-17T12:37:12Z

⚪ 2024-05-17 12:37:12 UTC Pre-commit check for a30088c has started.
⚪ 2024-05-17 12:37:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-17 12:38:37 UTC Build successful.
⚪ 2024-05-17 12:40:01 UTC Tests are running...
🟢 2024-05-17 12:41:36 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1	1	0	0	0	0

github-actions · 2024-05-17T12:37:21Z

⚪ 2024-05-17 12:37:21 UTC Pre-commit check for a30088c has started.
⚪ 2024-05-17 12:37:24 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-17 12:39:01 UTC Build successful.
⚪ 2024-05-17 12:40:28 UTC Tests are running...
🟢 2024-05-17 12:42:13 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1	1	0	0	0	0

github-actions · 2024-05-17T12:50:51Z

⚪ 2024-05-17 12:50:50 UTC Pre-commit check for 7f01a77 has started.
⚪ 2024-05-17 12:50:53 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-17 12:52:10 UTC Build successful.
⚪ 2024-05-17 12:53:38 UTC Tests are running...
🟢 2024-05-17 12:55:24 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1	1	0	0	0	0

github-actions · 2024-05-17T12:50:57Z

⚪ 2024-05-17 12:50:57 UTC Pre-commit check for 7f01a77 has started.
⚪ 2024-05-17 12:50:59 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-17 12:52:05 UTC Build successful.
⚪ 2024-05-17 12:53:31 UTC Tests are running...
🟢 2024-05-17 12:55:22 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1	1	0	0	0	0

github-actions · 2024-05-17T12:51:00Z

⚪ 2024-05-17 12:51:00 UTC Pre-commit check for 7f01a77 has started.
⚪ 2024-05-17 12:51:02 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-17 12:52:11 UTC Build successful.

github-actions · 2024-05-17T14:55:24Z

⚪ 2024-05-17 14:55:24 UTC Pre-commit check for 0a80542 has started.
⚪ 2024-05-17 14:55:27 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-17 14:58:29 UTC Build successful.
⚫ 2024-05-17 14:59:35 UTC Check cancelled

github-actions · 2024-05-17T14:55:46Z

⚪ 2024-05-17 14:55:45 UTC Pre-commit check for 0a80542 has started.
⚪ 2024-05-17 14:55:48 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-17 14:57:49 UTC Build successful.

github-actions · 2024-05-17T14:57:57Z

⚪ 2024-05-17 14:57:57 UTC Pre-commit check for 0a80542 has started.
⚪ 2024-05-17 14:57:59 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-05-17 14:59:35 UTC Check cancelled

github-actions · 2024-05-17T15:00:46Z

⚪ 2024-05-17 15:00:46 UTC Pre-commit check for 0015a91 has started.
⚪ 2024-05-17 15:00:47 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-17 15:01:55 UTC Build successful.

github-actions · 2024-05-17T15:01:37Z

⚪ 2024-05-17 15:01:36 UTC Pre-commit check for 0015a91 has started.
⚪ 2024-05-17 15:01:38 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-17 15:02:36 UTC Build successful.
⚪ 2024-05-17 15:03:55 UTC Tests are running...
🟢 2024-05-17 15:05:27 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1	1	0	0	0	0

github-actions · 2024-05-17T15:02:53Z

⚪ 2024-05-17 15:02:53 UTC Pre-commit check for 0015a91 has started.
⚪ 2024-05-17 15:02:54 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-17 15:04:47 UTC Build successful.
⚪ 2024-05-17 15:06:14 UTC Tests are running...
🟢 2024-05-17 15:07:52 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1	1	0	0	0	0

ydb/core/external_sources/hive_metastore/hive_metastore_client.h

ydb/core/external_sources/hive_metastore/hive_metastore_client.cpp

uzhastik · 2024-05-18T11:48:11Z

ydb/core/external_sources/hive_metastore/hive_metastore_client.h

+    TThreadPool ThreadPool;
+};
+
+}


просят newline

github-actions · 2024-05-20T21:52:45Z

⚪ 2024-05-20 21:52:44 UTC Pre-commit check for 149bb7c has started.
⚪ 2024-05-20 21:52:46 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-20 21:53:45 UTC Build successful.
⚪ 2024-05-20 21:54:55 UTC Tests are running...
🟢 2024-05-20 21:59:49 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
3	3	0	0	0	0

github-actions · 2024-05-20T21:54:56Z

⚪ 2024-05-20 21:54:56 UTC Pre-commit check for 149bb7c has started.
⚪ 2024-05-20 21:54:59 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-20 21:56:12 UTC Build successful.
⚪ 2024-05-20 21:57:49 UTC Tests are running...
🟢 2024-05-20 22:01:27 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
3	3	0	0	0	0

github-actions · 2024-05-20T21:55:07Z

⚪ 2024-05-20 21:55:07 UTC Pre-commit check for 149bb7c has started.
⚪ 2024-05-20 21:55:09 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-20 21:56:19 UTC Build successful.

uzhastik · 2024-05-21T05:28:48Z

ydb/core/external_sources/hive_metastore/ut/common.h

+
+void WaitHiveMetastore(const TString& host, int32_t port, const TString& database);
+
+}


В нескольких файлах просят пустую строку добавить в конце

github-actions · 2024-05-21T06:09:37Z

⚪ 2024-05-21 06:09:37 UTC Pre-commit check for a0d4cc7 has started.
⚪ 2024-05-21 06:09:39 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-21 06:11:26 UTC Build successful.

github-actions · 2024-05-21T06:09:47Z

⚪ 2024-05-21 06:09:47 UTC Pre-commit check for a0d4cc7 has started.
⚪ 2024-05-21 06:09:49 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-21 06:11:33 UTC Build successful.
⚪ 2024-05-21 06:13:01 UTC Tests are running...
🟢 2024-05-21 06:15:47 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
3	3	0	0	0	0

github-actions · 2024-05-21T06:10:05Z

⚪ 2024-05-21 06:10:04 UTC Pre-commit check for a0d4cc7 has started.
⚪ 2024-05-21 06:10:07 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-21 06:11:59 UTC Build successful.
⚪ 2024-05-21 06:13:23 UTC Tests are running...
🟢 2024-05-21 06:16:33 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
3	3	0	0	0	0

github-actions bot added the not-for-changelog label May 16, 2024

dorooleg requested review from a team as code owners May 16, 2024 22:43

dorooleg force-pushed the hive_metastore_client branch from bfcfe09 to 69c1062 Compare May 16, 2024 22:48

uzhastik reviewed May 17, 2024

View reviewed changes

uzhastik reviewed May 18, 2024

View reviewed changes

dorooleg added 4 commits May 20, 2024 21:50

cleanup

d798991

cleanup

ef22fd9

cleanup

27baed1

metastore fetcher has been added

ea2c989

dorooleg force-pushed the hive_metastore_client branch from cf54814 to ea2c989 Compare May 20, 2024 21:50

uzhastik reviewed May 21, 2024

View reviewed changes

last new line has been added for different files

f2dd09d

uzhastik approved these changes May 21, 2024

View reviewed changes

dorooleg merged commit c71c5b0 into ydb-platform:main May 21, 2024
5 checks passed

serbel324 mentioned this pull request May 24, 2024

Add description of new ICB controls for CMS #4818

Merged

This was referenced May 27, 2024

Cli changes for autoscaling #4871

Closed

Fix getting mid of range for autoscaling #4884

Closed

Fix getting mid range #4885

Merged

MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024

hive metastore client has been added (ydb-platform#4593)

e65dc1c

niksaveliev mentioned this pull request May 29, 2024

Autoscaling logs #4976

Merged

This was referenced May 29, 2024

YQ-3292 fixed kqprun ResourceBrokerConfig passing #4994

Merged

Added ExecutionId for script execution logs #5014

Merged

This was referenced May 30, 2024

Forbid autoscaling with size retention #5054

Merged

Mute split by load ut #5264

Closed

Mute split by load ut #5267

Closed

Mute split by load ut #5272

Merged

This was referenced Jun 7, 2024

Fix build #5310

Merged

Fix split by load ut #5383

Merged

niksaveliev mentioned this pull request Jun 17, 2024

Fix win build #5622

Closed


		void WaitHiveMetastore(const TString& host, int32_t port, const TString& database);

		}

hive metastore client has been added #4593

hive metastore client has been added #4593

Conversation

dorooleg commented May 16, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented May 16, 2024 • edited Loading

github-actions bot commented May 16, 2024 • edited Loading

github-actions bot commented May 16, 2024 • edited Loading

github-actions bot commented May 16, 2024 • edited Loading

github-actions bot commented May 16, 2024 • edited Loading

github-actions bot commented May 16, 2024 • edited Loading

github-actions bot commented May 16, 2024

✅ Documentation build

github-actions bot commented May 16, 2024 • edited Loading

github-actions bot commented May 16, 2024 • edited Loading

github-actions bot commented May 16, 2024 • edited Loading

uzhastik commented May 17, 2024

uzhastik May 17, 2024

Choose a reason for hiding this comment

dorooleg May 17, 2024

Choose a reason for hiding this comment

uzhastik May 17, 2024

Choose a reason for hiding this comment

dorooleg May 17, 2024 • edited Loading

Choose a reason for hiding this comment

uzhastik May 17, 2024

Choose a reason for hiding this comment

github-actions bot commented May 17, 2024 • edited Loading

github-actions bot commented May 17, 2024 • edited Loading

github-actions bot commented May 17, 2024 • edited Loading

github-actions bot commented May 17, 2024 • edited Loading

github-actions bot commented May 17, 2024 • edited Loading

github-actions bot commented May 17, 2024 • edited Loading

github-actions bot commented May 17, 2024 • edited Loading

github-actions bot commented May 17, 2024 • edited Loading

github-actions bot commented May 17, 2024 • edited Loading

github-actions bot commented May 17, 2024 • edited Loading

github-actions bot commented May 17, 2024 • edited Loading

github-actions bot commented May 17, 2024 • edited Loading

uzhastik May 18, 2024

Choose a reason for hiding this comment

github-actions bot commented May 20, 2024 • edited Loading

github-actions bot commented May 20, 2024 • edited Loading

github-actions bot commented May 20, 2024 • edited Loading

uzhastik May 21, 2024

Choose a reason for hiding this comment

github-actions bot commented May 21, 2024 • edited Loading

github-actions bot commented May 21, 2024 • edited Loading

github-actions bot commented May 21, 2024 • edited Loading

github-actions bot commented May 16, 2024 •

edited

Loading

github-actions bot commented May 16, 2024 •

edited

Loading

github-actions bot commented May 16, 2024 •

edited

Loading

github-actions bot commented May 16, 2024 •

edited

Loading

github-actions bot commented May 16, 2024 •

edited

Loading

github-actions bot commented May 16, 2024 •

edited

Loading

github-actions bot commented May 16, 2024 •

edited

Loading

github-actions bot commented May 16, 2024 •

edited

Loading

github-actions bot commented May 16, 2024 •

edited

Loading

dorooleg May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading