Fix cross join with list iterator. #4683

Tony-Romanov · 2024-05-20T13:40:37Z

No description provided.

github-actions · 2024-05-20T13:43:03Z

⚪ 2024-05-20 13:43:02 UTC Pre-commit check for e34dab3 has started.
⚪ 2024-05-20 13:43:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-20 13:46:44 UTC Build successful.
⚪ 2024-05-20 13:48:25 UTC Tests are running...
🔴 2024-05-20 15:41:52 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
69207	56488	0	17	12682	20

github-actions · 2024-05-20T13:43:47Z

⚪ 2024-05-20 13:43:47 UTC Pre-commit check for e34dab3 has started.
⚪ 2024-05-20 13:43:50 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-20 13:48:07 UTC Build successful.

github-actions · 2024-05-20T13:44:25Z

⚪ 2024-05-20 13:44:25 UTC Pre-commit check for e34dab3 has started.
⚪ 2024-05-20 13:44:27 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-20 13:48:13 UTC Build successful.
⚪ 2024-05-20 13:49:56 UTC Tests are running...
🔴 2024-05-20 15:37:55 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10244	10155	0	31	48	10

github-actions · 2024-05-20T15:50:41Z

⚪ 2024-05-20 15:50:40 UTC Pre-commit check for 1e205fe has started.
⚪ 2024-05-20 15:50:44 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-20 15:53:45 UTC Build successful.
⚪ 2024-05-20 15:55:29 UTC Tests are running...
🔴 2024-05-20 17:45:46 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
69204	56510	0	4	12681	9

github-actions · 2024-05-20T15:52:54Z

⚪ 2024-05-20 15:52:53 UTC Pre-commit check for 1e205fe has started.
⚪ 2024-05-20 15:52:56 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-20 15:56:07 UTC Build successful.

github-actions · 2024-05-20T15:52:55Z

⚪ 2024-05-20 15:52:54 UTC Pre-commit check for 1e205fe has started.
⚪ 2024-05-20 15:52:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-20 15:55:28 UTC Build successful.
⚪ 2024-05-20 15:57:12 UTC Tests are running...
🔴 2024-05-20 17:47:08 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10250	10152	0	25	58	15

github-actions · 2024-05-21T09:17:09Z

⚪ 2024-05-21 09:17:09 UTC Pre-commit check for 04d4301 has started.
⚪ 2024-05-21 09:17:12 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-21 09:20:44 UTC Build successful.
⚪ 2024-05-21 09:22:30 UTC Tests are running...
🔴 2024-05-21 11:12:29 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10256	10158	0	34	49	15

github-actions · 2024-05-21T09:17:18Z

⚪ 2024-05-21 09:17:17 UTC Pre-commit check for 04d4301 has started.
⚪ 2024-05-21 09:17:20 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-21 09:21:22 UTC Build successful.

github-actions · 2024-05-21T09:19:36Z

⚪ 2024-05-21 09:19:36 UTC Pre-commit check for 04d4301 has started.
⚪ 2024-05-21 09:19:39 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-21 09:23:14 UTC Build successful.
⚪ 2024-05-21 09:24:56 UTC Tests are running...
🟢 2024-05-21 11:14:56 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
69223	56523	0	0	12692	8

mxkovalev · 2024-05-21T10:45:05Z

ydb/library/yql/core/peephole_opt/yql_opt_peephole_physical.cpp

+                        auto deps = children.back()->ChildrenList();
+                        deps.emplace_back(upperArg);
+                        children.back() = ctx.ChangeChildren(*children.back(), std::move(deps));
+;                       break;


redundant ;

mxkovalev · 2024-05-21T10:50:27Z

When I rerun an example from the issue, data generated from cross_join(a, b) and cross_join(b, a) are very different.

github-actions · 2024-05-21T12:57:43Z

⚪ 2024-05-21 12:57:43 UTC Pre-commit check for 14e7912 has started.
⚪ 2024-05-21 12:57:46 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-21 13:01:21 UTC Build successful.
⚪ 2024-05-21 13:03:11 UTC Tests are running...
🔴 2024-05-21 14:57:03 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10258	10152	0	36	54	16

github-actions · 2024-05-21T13:03:45Z

⚪ 2024-05-21 13:03:45 UTC Pre-commit check for 14e7912 has started.
⚪ 2024-05-21 13:03:48 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-21 13:07:33 UTC Build successful.

github-actions · 2024-05-21T13:05:36Z

⚪ 2024-05-21 13:05:36 UTC Pre-commit check for 14e7912 has started.
⚪ 2024-05-21 13:05:37 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-21 13:09:03 UTC Build successful.
⚪ 2024-05-21 13:10:40 UTC Tests are running...
🔴 2024-05-21 15:06:10 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
69227	56508	0	4	12696	19

This reverts commit 22bd429.

…platform#7570)

Fix cross join with list iterator.

e39f10e

Tony-Romanov added area/yql YQL query language issues bugfix labels May 20, 2024

Tony-Romanov linked an issue May 20, 2024 that may be closed by this pull request

YQL: Cross join results depends on input order #4587

Closed

Merge branch 'ydb-platform:main' into cross_join

b9e73e6

Tony-Romanov requested a review from mxkovalev May 20, 2024 18:21

Tony-Romanov marked this pull request as ready for review May 20, 2024 18:22

Tony-Romanov requested a review from a team as a code owner May 20, 2024 18:22

Tony-Romanov enabled auto-merge (squash) May 20, 2024 18:22

Fix misprint

5ec2782

mxkovalev reviewed May 21, 2024

View reviewed changes

Tony-Romanov and others added 2 commits May 21, 2024 14:54

Fixed.

9fe1c14

Merge branch 'ydb-platform:main' into cross_join

1875065

mxkovalev approved these changes May 21, 2024

View reviewed changes

Tony-Romanov merged commit 22bd429 into ydb-platform:main May 21, 2024
3 of 5 checks passed

Tony-Romanov deleted the cross_join branch May 21, 2024 14:34

serbel324 mentioned this pull request May 24, 2024

Add description of new ICB controls for CMS #4818

Merged

This was referenced May 27, 2024

Cli changes for autoscaling #4871

Closed

Fix getting mid of range for autoscaling #4884

Closed

Fix getting mid range #4885

Merged

MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024

Fix cross join with list iterator. (ydb-platform#4683)

4ecb15b

niksaveliev mentioned this pull request May 29, 2024

Autoscaling logs #4976

Merged

This was referenced May 29, 2024

YQ-3292 fixed kqprun ResourceBrokerConfig passing #4994

Merged

Added ExecutionId for script execution logs #5014

Merged

This was referenced May 30, 2024

Forbid autoscaling with size retention #5054

Merged

Mute split by load ut #5264

Closed

Mute split by load ut #5267

Closed

Mute split by load ut #5272

Merged

This was referenced Jun 7, 2024

Fix build #5310

Merged

Fix split by load ut #5383

Merged

niksaveliev mentioned this pull request Jun 17, 2024

Fix win build #5622

Closed

mxkovalev added a commit to mxkovalev/ydb that referenced this pull request Aug 8, 2024

Revert "Fix cross join with list iterator. (ydb-platform#4683)"

56f5a3d

This reverts commit 22bd429.

mxkovalev added a commit that referenced this pull request Aug 8, 2024

Revert "Fix cross join with list iterator. (#4683)" (#7570)

32e8f89

nepal pushed a commit to nepal/ydb that referenced this pull request Aug 12, 2024

Revert "Fix cross join with list iterator. (ydb-platform#4683)" (ydb-…

cd8319d

…platform#7570)

GrigoriyPA mentioned this pull request Aug 13, 2024

YQ kqprun pass actor system config #7693

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix cross join with list iterator. #4683

Fix cross join with list iterator. #4683

Tony-Romanov commented May 20, 2024

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

mxkovalev May 21, 2024

mxkovalev commented May 21, 2024

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

Fix cross join with list iterator. #4683

Fix cross join with list iterator. #4683

Conversation

Tony-Romanov commented May 20, 2024

github-actions bot commented May 20, 2024 • edited Loading

github-actions bot commented May 20, 2024 • edited Loading

github-actions bot commented May 20, 2024 • edited Loading

github-actions bot commented May 20, 2024 • edited Loading

github-actions bot commented May 20, 2024 • edited Loading

github-actions bot commented May 20, 2024 • edited Loading

github-actions bot commented May 21, 2024 • edited Loading

github-actions bot commented May 21, 2024 • edited Loading

github-actions bot commented May 21, 2024 • edited Loading

mxkovalev May 21, 2024

Choose a reason for hiding this comment

mxkovalev commented May 21, 2024

github-actions bot commented May 21, 2024 • edited Loading

github-actions bot commented May 21, 2024 • edited Loading

github-actions bot commented May 21, 2024 • edited Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading