Always add 'u-' prefix to the dedicated YDB database endpoint during resolving #4688

vitalyisaev2 · 2024-05-20T15:00:47Z

Changelog entry

Always add 'u-' prefix to the dedicated YDB database endpoint during resolving

Changelog category

Bugfix (YQ-3163)

Additional information

...

github-actions · 2024-05-20T15:04:11Z

⚪ 2024-05-20 15:04:11 UTC Pre-commit check for 34bc5de has started.
⚪ 2024-05-20 15:04:14 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-20 15:06:01 UTC Build successful.

github-actions · 2024-05-20T15:04:26Z

⚪ 2024-05-20 15:04:25 UTC Pre-commit check for 34bc5de has started.
⚪ 2024-05-20 15:04:28 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-20 15:06:21 UTC Build successful.
⚪ 2024-05-20 15:08:10 UTC Tests are running...
🔴 2024-05-20 16:59:26 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9242	9186	0	17	27	12

github-actions · 2024-05-20T15:06:51Z

⚪ 2024-05-20 15:06:51 UTC Pre-commit check for 34bc5de has started.
⚪ 2024-05-20 15:06:53 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-20 15:08:43 UTC Build successful.
⚪ 2024-05-20 15:10:26 UTC Tests are running...
🔴 2024-05-20 16:42:42 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
36521	31732	0	4	4776	9

ydb/core/fq/libs/actors/database_resolver.cpp

uzhastik · 2024-05-20T16:33:18Z

ydb/core/fq/libs/actors/ut/database_resolver_ut.cpp

@@ -264,7 +286,7 @@ Y_UNIT_TEST_SUITE(TDatabaseResolverTests) {
            R"(
                {
                    "endpoint":"grpcs://lb.etn021us5r9rhld1vgbh.ydb.mdb.yandexcloud.net:2135/?database=/ru-central1/b1g7jdjqd07qg43c4fmp/etn021us5r9rhld1vgbh",
-                    "storageConfig":{"storageSizeLimit":107374182400}
+                    "dedicatedDatabase":{"resuorcePresetId": "medium"}


думаю, тут норм был пример
и у тебя опечатка

Опечатку поправил. А по поводу того, что storageConfig заменился на dedicatedDatabase, я сознательно это сделал в парсере ответов, т. к. это выглядит более явно. Если в ответе API есть секция dedicatedDatabase, значит это со 100% вероятностью dedicated database. Со storageConfig это было не так очевидно.

github-actions · 2024-05-21T07:59:41Z

⚪ 2024-05-21 07:59:41 UTC Pre-commit check for 7d05409 has started.
⚪ 2024-05-21 07:59:43 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-21 08:01:27 UTC Build successful.

github-actions · 2024-05-21T08:02:08Z

⚪ 2024-05-21 08:02:08 UTC Pre-commit check for 7d05409 has started.
⚪ 2024-05-21 08:02:13 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-21 08:04:03 UTC Build successful.
⚪ 2024-05-21 08:05:47 UTC Tests are running...
🟢 2024-05-21 09:35:14 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
36531	31739	0	0	4785	7

github-actions · 2024-05-21T08:02:16Z

⚪ 2024-05-21 08:02:16 UTC Pre-commit check for 7d05409 has started.
⚪ 2024-05-21 08:02:20 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-21 08:04:18 UTC Build successful.
⚪ 2024-05-21 08:06:07 UTC Tests are running...
🔴 2024-05-21 10:01:19 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9234	9174	0	24	27	9

…resolving (ydb-platform#4688)

* Fix connection error handling in database resolver (#2990) * Always add 'u-' prefix to the dedicated YDB database endpoint during resolving (#4688)

…resolving (ydb-platform#4688)

vitalyisaev2 added 4 commits April 26, 2024 19:48

Mute YDB tests

0a7c346

Merge branch 'main' of github.com:vitalyisaev2/ydb into main

5af4b61

Merge branch 'main' of github.com:vitalyisaev2/ydb into main

ebdf7f2

Always add 'u-' prefix to endpoint when resolving Dedicated YDB

775b537

vitalyisaev2 requested a review from a team as a code owner May 20, 2024 15:00

github-actions bot added the bugfix label May 20, 2024

uzhastik reviewed May 20, 2024

View reviewed changes

kardymonds previously approved these changes May 21, 2024

View reviewed changes

Review fix

55501de

vitalyisaev2 dismissed kardymonds’s stale review via 55501de May 21, 2024 07:58

kardymonds approved these changes May 21, 2024

View reviewed changes

vitalyisaev2 merged commit 90ae575 into ydb-platform:main May 21, 2024
4 of 5 checks passed

vitalyisaev2 added a commit to vitalyisaev2/ydb that referenced this pull request May 21, 2024

Always add 'u-' prefix to the dedicated YDB database endpoint during …

739f3fc

…resolving (ydb-platform#4688)

vitalyisaev2 added a commit to vitalyisaev2/ydb that referenced this pull request May 21, 2024

Always add 'u-' prefix to the dedicated YDB database endpoint during …

c71c4fe

…resolving (ydb-platform#4688)

This was referenced May 21, 2024

Merge from main acfab9b 90ae575 #4717

Merged

Always add 'u-' prefix to the dedicated YDB database endpoint during resolving #4715

Merged

vitalyisaev2 added a commit that referenced this pull request May 21, 2024

Merge from main acfab9b 90ae575 (#4717)

e7ee081

* Fix connection error handling in database resolver (#2990) * Always add 'u-' prefix to the dedicated YDB database endpoint during resolving (#4688)

serbel324 mentioned this pull request May 24, 2024

Add description of new ICB controls for CMS #4818

Merged

This was referenced May 27, 2024

Cli changes for autoscaling #4871

Closed

Fix getting mid of range for autoscaling #4884

Closed

Fix getting mid range #4885

Merged

MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024

Always add 'u-' prefix to the dedicated YDB database endpoint during …

94a2556

…resolving (ydb-platform#4688)

niksaveliev mentioned this pull request May 29, 2024

Autoscaling logs #4976

Merged

GrigoriyPA mentioned this pull request May 29, 2024

YQ-3292 fixed kqprun ResourceBrokerConfig passing #4994

Merged

GrigoriyPA mentioned this pull request May 30, 2024

Added ExecutionId for script execution logs #5014

Merged

This was referenced May 30, 2024

Forbid autoscaling with size retention #5054

Merged

Mute split by load ut #5264

Closed

Mute split by load ut #5267

Closed

Mute split by load ut #5272

Merged

This was referenced Jun 7, 2024

Fix build #5310

Merged

Fix split by load ut #5383

Merged

niksaveliev mentioned this pull request Jun 17, 2024

Fix win build #5622

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Always add 'u-' prefix to the dedicated YDB database endpoint during resolving #4688

Always add 'u-' prefix to the dedicated YDB database endpoint during resolving #4688

vitalyisaev2 commented May 20, 2024

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

uzhastik May 20, 2024

vitalyisaev2 May 21, 2024

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

Always add 'u-' prefix to the dedicated YDB database endpoint during resolving #4688

Always add 'u-' prefix to the dedicated YDB database endpoint during resolving #4688

Conversation

vitalyisaev2 commented May 20, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented May 20, 2024 • edited Loading

github-actions bot commented May 20, 2024 • edited Loading

github-actions bot commented May 20, 2024 • edited Loading

uzhastik May 20, 2024

Choose a reason for hiding this comment

vitalyisaev2 May 21, 2024

Choose a reason for hiding this comment

github-actions bot commented May 21, 2024 • edited Loading

github-actions bot commented May 21, 2024 • edited Loading

github-actions bot commented May 21, 2024 • edited Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 20, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading