-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always add 'u-' prefix to the dedicated YDB database endpoint during resolving #4688
Conversation
⚪
|
⚪
|
@@ -264,7 +286,7 @@ Y_UNIT_TEST_SUITE(TDatabaseResolverTests) { | |||
R"( | |||
{ | |||
"endpoint":"grpcs://lb.etn021us5r9rhld1vgbh.ydb.mdb.yandexcloud.net:2135/?database=/ru-central1/b1g7jdjqd07qg43c4fmp/etn021us5r9rhld1vgbh", | |||
"storageConfig":{"storageSizeLimit":107374182400} | |||
"dedicatedDatabase":{"resuorcePresetId": "medium"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
думаю, тут норм был пример
и у тебя опечатка
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Опечатку поправил. А по поводу того, что storageConfig
заменился на dedicatedDatabase
, я сознательно это сделал в парсере ответов, т. к. это выглядит более явно. Если в ответе API есть секция dedicatedDatabase
, значит это со 100% вероятностью dedicated database. Со storageConfig
это было не так очевидно.
⚪
|
⚪
|
Changelog entry
Changelog category
Additional information
...