Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DB.CalculateReadSize #4728

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix DB.CalculateReadSize #4728

merged 2 commits into from
May 22, 2024

Conversation

kunga
Copy link
Member

@kunga kunga commented May 21, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Wrongly returned first index page size

@kunga kunga requested a review from snaury May 21, 2024 15:04
@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

⚪ 2024-05-21 15:04:31 UTC Pre-commit check for f3af53e has started.
⚪ 2024-05-21 15:04:33 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-21 15:30:54 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

⚪ 2024-05-21 15:06:01 UTC Pre-commit check for f3af53e has started.
⚪ 2024-05-21 15:06:05 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-21 15:34:13 UTC Build successful.
⚪ 2024-05-21 15:35:57 UTC Tests are running...
🔴 2024-05-21 17:22:15 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10331 10266 0 28 25 12

@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

⚪ 2024-05-21 15:06:37 UTC Pre-commit check for f3af53e has started.
⚪ 2024-05-21 15:06:40 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-21 15:37:32 UTC Build successful.
⚪ 2024-05-21 15:39:22 UTC Tests are running...
🔴 2024-05-21 17:19:03 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37786 32996 0 2 4785 3

snaury
snaury previously approved these changes May 21, 2024
View reviewed changes
ydb/core/tablet_flat/flat_dbase_sz_env.h Outdated Show resolved Hide resolved
@kunga kunga requested a review from snaury May 22, 2024 07:52
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

⚪ 2024-05-22 07:53:21 UTC Pre-commit check for 3e9854b has started.
⚪ 2024-05-22 07:53:24 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-22 08:21:09 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

⚪ 2024-05-22 07:53:33 UTC Pre-commit check for 3e9854b has started.
⚪ 2024-05-22 07:53:35 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-22 08:25:53 UTC Build successful.
⚪ 2024-05-22 08:27:44 UTC Tests are running...
🔴 2024-05-22 10:24:21 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10351 10292 0 28 23 8

@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

⚪ 2024-05-22 07:53:34 UTC Pre-commit check for 3e9854b has started.
⚪ 2024-05-22 07:53:36 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-22 08:24:07 UTC Build successful.
⚪ 2024-05-22 08:25:54 UTC Tests are running...
🔴 2024-05-22 09:59:18 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37791 32997 0 2 4785 7

@kunga kunga merged commit 7329ec4 into ydb-platform:main May 22, 2024
4 of 6 checks passed
@serbel324 serbel324 mentioned this pull request May 24, 2024
Merged
This was referenced May 27, 2024
Closed
Closed
Merged
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@kunga @MrLolthe1st
Fix DB.CalculateReadSize (ydb-platform#4728)
4896958
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
kunga added a commit to kunga/ydb that referenced this pull request May 29, 2024
@kunga
Fix DB.CalculateReadSize (ydb-platform#4728)
52830a0
@kunga kunga mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request May 30, 2024
Merged
kunga added a commit that referenced this pull request Jun 3, 2024
@kunga
24-1 Fix DB.CalculateReadSize (#4728) (#4977)
178cf6e
This was referenced Jun 6, 2024
Closed
Closed
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 7, 2024
Merged
This was referenced Jun 7, 2024
Closed
Closed
This was referenced Jun 10, 2024
Merged
Closed
@CyberROFL CyberROFL mentioned this pull request Jun 19, 2024
Closed
@CyberROFL CyberROFL mentioned this pull request Jul 12, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snaury snaury snaury approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kunga @snaury