-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve CS-resharding #4775
improve CS-resharding #4775
Conversation
tests fixes
⚪ |
⚪ |
⚪ |
⚪
|
⚪
|
⚪
|
⚪
|
@@ -176,6 +176,10 @@ void AddOptionalValue(Ydb::TOperationId& proto, const TString& key, const TStrin | |||
} | |||
|
|||
Ydb::TOperationId::EKind ParseKind(const TStringBuf value) { | |||
if (value.StartsWith("ss/backgrounds")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это уже имя, видимое пользователям. Оно используется в pseudo uri, поэтому я бы поостерёгся использовать /
, чтобы не столкнуться потом вдруг с необходимостью применять urldecode.
И само имя я бы поискал получше: process
, task
, schemeprocess
и т.п.
tests
fixes