Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReadLogContinue race on stop #4791

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix ReadLogContinue race on stop #4791

merged 1 commit into from
May 23, 2024

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented May 23, 2024

Changelog entry

Fix ReadLogContinue race on stop

Changelog category

  • Bugfix

Additional information

Plain pointer was replaced by shared/weak pointer.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 15:39:57 UTC Pre-commit check for bfe2b2e has started.
⚪ 2024-05-23 15:42:27 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-23 15:44:59 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 15:39:58 UTC Pre-commit check for bfe2b2e has started.
⚪ 2024-05-23 15:42:35 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-23 15:44:52 UTC Build successful.
⚪ 2024-05-23 15:45:05 UTC Tests are running...
🔴 2024-05-23 17:46:26 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9980 9909 0 34 26 11

@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 15:40:19 UTC Pre-commit check for bfe2b2e has started.
⚪ 2024-05-23 15:42:53 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-23 15:45:03 UTC Build successful.
⚪ 2024-05-23 15:45:17 UTC Tests are running...
🔴 2024-05-23 17:06:09 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14099 12792 0 1 1299 7

@alexvru alexvru enabled auto-merge (squash) May 23, 2024 18:20
SammyVimes
SammyVimes approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@SammyVimes SammyVimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexvru alexvru merged commit 95371ef into ydb-platform:main May 23, 2024
4 of 6 checks passed
@alexvru alexvru deleted the pdisk/fix-read-log-continue branch May 23, 2024 18:36
@serbel324 serbel324 mentioned this pull request May 24, 2024
Merged
This was referenced May 27, 2024
Closed
Closed
Merged
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@alexvru @MrLolthe1st
Fix ReadLogContinue race on stop (ydb-platform#4791)
dcd014e
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request May 30, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
Merged
This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 19, 2024
Open
This was referenced Jun 23, 2024
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyVimes SammyVimes SammyVimes approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexvru @SammyVimes