Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed up through don't ask type each comparison (valuable on flame grph) #4855

Merged
merged 1 commit into from
May 26, 2024
Merged

speed up through don't ask type each comparison (valuable on flame grph) #4855

merged 1 commit into from
May 26, 2024

Conversation

ivanmorozov333
Copy link
Collaborator

  • Performance improvement

@github-actions GitHub Actions
Copy link

github-actions bot commented May 25, 2024 •
edited
Loading

⚪ 2024-05-25 11:52:11 UTC Pre-commit check for 89517af has started.
⚪ 2024-05-25 11:54:49 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-25 12:04:25 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 25, 2024 •
edited
Loading

⚪ 2024-05-25 11:52:19 UTC Pre-commit check for 89517af has started.
⚪ 2024-05-25 11:54:58 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-25 12:04:59 UTC Build successful.
⚪ 2024-05-25 12:05:11 UTC Tests are running...
🔴 2024-05-25 14:01:53 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9575 9508 0 23 28 16

@github-actions GitHub Actions
Copy link

github-actions bot commented May 25, 2024 •
edited
Loading

⚪ 2024-05-25 11:52:36 UTC Pre-commit check for 89517af has started.
⚪ 2024-05-25 11:55:07 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-25 12:04:24 UTC Build successful.
⚪ 2024-05-25 12:04:40 UTC Tests are running...
🔴 2024-05-25 13:40:17 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37069 32275 0 5 4781 8

@ivanmorozov333 ivanmorozov333 merged commit e8076a8 into ydb-platform:main May 26, 2024
9 of 13 checks passed
@ivanmorozov333 ivanmorozov333 deleted the speedup_comparision branch May 26, 2024 05:09
This was referenced May 27, 2024
Closed
Closed
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request May 28, 2024
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request May 29, 2024
@ivanmorozov333 @zverevgeny
speed up through don't ask type each comparison (valuable on flame gr…
494c687 
…ph) (ydb-platform#4855)
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request May 30, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jun 2, 2024
@ivanmorozov333 @zverevgeny
speed up through don't ask type each comparison (valuable on flame gr…
a6bb84d 
…ph) (ydb-platform#4855)
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 14, 2024
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jun 17, 2024
@ivanmorozov333 @zverevgeny
speed up through don't ask type each comparison (valuable on flame gr…
e79ea4c 
…ph) (ydb-platform#4855)
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jun 18, 2024
@ivanmorozov333 @zverevgeny
speed up through don't ask type each comparison (valuable on flame gr…
2842333 
…ph) (ydb-platform#4855)
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jun 18, 2024
@ivanmorozov333 @zverevgeny
speed up through don't ask type each comparison (valuable on flame gr…
77c5a19 
…ph) (ydb-platform#4855)
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jun 18, 2024
@zverevgeny
speed up through don't ask type each comparison (valuable on flame gr…
4ed69ae 
…ph) (ydb-platform#4855)

 Plus manual change: support comparision for Decimals
This was referenced Jun 19, 2024
Open
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivanmorozov333 @zverevgeny