fixed github MR approval status

noti.py

@@ -380,9 +380,10 @@ def failed_pipeline_jobs(self):
 
         return self._failed_pipeline_jobs
 
+    # As long as the state is not BLOCKED, we should consider the MR is approved.
     @property
     def approved(self):
-        return self._pr.mergeable
+        return self._pr.mergeable and self._pr.mergeable_state != 'blocked'
 
     @property
     def reviews(self):

tests/unit/fixtures/github.py

@@ -26,11 +26,12 @@ def html_url(self):
 
 class DummyPR:
 
-    def __init__(self, comments=[]):
+    def __init__(self, comments=[], mergeable_state='clean'):
         self._head = MagicMock()
         self._head.ref = '_branch_'
         self._head.sha = '_sha_'
         self._comments = comments
+        self._mergeable_state = mergeable_state
 
     def get_comments(self):
         return self._comments
@@ -51,6 +52,10 @@ def head(self):
     def mergeable(self):
         return True
 
+    @property
+    def mergeable_state(self):
+        return self._mergeable_state
+
 class DummyBuild:
 
     def __init__(self, state='success'):

tests/unit/test_github_pr.py

@@ -41,6 +41,10 @@ def test_failed_pipeline_jobs(self, default_pr):
     def test_approved(self, default_pr):
         assert default_pr.approved
 
+    def test_not_approved(self):
+        pr = GithubPR(MagicMock(), mock.DummyPR(mergeable_state='blocked'))
+        assert not pr.approved
+
     def test_url(self, default_pr):
         assert default_pr.url == '_url_'