Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Vaults via EthPM #5

Closed
fubuloubu opened this issue Oct 10, 2020 · 3 comments
Closed

Release Vaults via EthPM #5

fubuloubu opened this issue Oct 10, 2020 · 3 comments
Labels
enhancement New feature or request p3 Fix if time

Comments

@fubuloubu
Copy link
Member

Also not sure if Abstracts can be released via EthPM, but the Strategy interface should be possible.

fubuloubu added a commit that referenced this issue Oct 14, 2020
@fubuloubu
Copy link
Member Author

Edit: ethPM support on Brownie is broken, and not compatible with v3 (but using it for versioning aka #3 anyways)

@milkyklim milkyklim added the enhancement New feature or request label Oct 21, 2020
@milkyklim milkyklim added this to To do in Development via automation Oct 21, 2020
@saltyfacu saltyfacu added this to Low priority in Vaults & Strategies Feb 2, 2021
@saltyfacu saltyfacu added the p3 Fix if time label Feb 4, 2021
orbxball pushed a commit to orbxball/yearn-vaults that referenced this issue Aug 8, 2021
@milkyklim
Copy link
Contributor

@fubuloubu Was this ever done?

@fubuloubu
Copy link
Member Author

No. We can close this for now. We have setup the best way we can to share code for things like the strategy mix

Development automation moved this from To do to Done Sep 30, 2021
Vaults & Strategies automation moved this from Backlog to Done Sep 30, 2021
pandadefi added a commit that referenced this issue Oct 25, 2022
* refactor: reduce base strategy size (#422)

* refactor: reduce base strategy size

* fix: do not add onlyManagement

* fix: allow harvest on add strategy block (#428)

* fix: allow harvest on add strategy block

* docs: comment

Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>

Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>

* fix: updated setRewards (#474)

* feat: add deposit and withdraw events (#499)

* feat: add event to add_event_to_setLockedProfitDegradation (#506)

* fix: implement modifiers (#513)

* fix: implement modifiers

* fix: typo

* fix: formatting

* fix: test same time harvest not allowed

* fix: merge mistake

* fix: gov event

* fix: add pps protection

* chore: update solc version

* chore: add FeeReport event

* chore: update FeeReport

* chore: bump vyper version

* chore: bump brownie version

* test: fixes

* chore: bump ganache version

* style: fix format

* test: airdrop do not change pps

* test: make sure deposits are still possible

* ci: cancel same branch run

* style: fix python formating

* fix: wrong math operation

* fix: tests

* fix: add missing WithdrawFromStrategy event

* docs: fix comment

* chore: cleanup docs folder

* chore: remove not used code

* feat: prevent fork replay EIP712 signature (#3)

* chore: bump version

* fix: clone check (#5)

* fix: make sure strategy isn't in emergency mode when updating debt (#4)

* fix: change permit definition (#6)

* fix: change permit definition

* fix: tests

* chore: format

* fix: do not use external call

* fix: allow setEmergency after revoke (#7)

Co-authored-by: Steffel <2143646+steffenix@users.noreply.github.com>
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
Co-authored-by: John Bergschneider <jhb10c@my.fsu.edu>
Co-authored-by: jmonteer <68742302+jmonteer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p3 Fix if time
Projects
Development
  
Done
Development

No branches or pull requests

3 participants