refactor: reduce base strategy size #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
poolpitako
approved these changes
Jun 25, 2021
This was referenced Jun 29, 2021
fubuloubu
pushed a commit
that referenced
this pull request
Jul 9, 2021
* refactor: reduce base strategy size * fix: do not add onlyManagement
fubuloubu
pushed a commit
that referenced
this pull request
Jul 9, 2021
* refactor: reduce base strategy size * fix: do not add onlyManagement
orbxball
pushed a commit
to orbxball/yearn-vaults
that referenced
this pull request
Aug 8, 2021
* refactor: reduce base strategy size * fix: do not add onlyManagement
pandadefi
added a commit
that referenced
this pull request
Oct 25, 2022
* refactor: reduce base strategy size (#422) * refactor: reduce base strategy size * fix: do not add onlyManagement * fix: allow harvest on add strategy block (#428) * fix: allow harvest on add strategy block * docs: comment Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com> Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com> * fix: updated setRewards (#474) * feat: add deposit and withdraw events (#499) * feat: add event to add_event_to_setLockedProfitDegradation (#506) * fix: implement modifiers (#513) * fix: implement modifiers * fix: typo * fix: formatting * fix: test same time harvest not allowed * fix: merge mistake * fix: gov event * fix: add pps protection * chore: update solc version * chore: add FeeReport event * chore: update FeeReport * chore: bump vyper version * chore: bump brownie version * test: fixes * chore: bump ganache version * style: fix format * test: airdrop do not change pps * test: make sure deposits are still possible * ci: cancel same branch run * style: fix python formating * fix: wrong math operation * fix: tests * fix: add missing WithdrawFromStrategy event * docs: fix comment * chore: cleanup docs folder * chore: remove not used code * feat: prevent fork replay EIP712 signature (#3) * chore: bump version * fix: clone check (#5) * fix: make sure strategy isn't in emergency mode when updating debt (#4) * fix: change permit definition (#6) * fix: change permit definition * fix: tests * chore: format * fix: do not use external call * fix: allow setEmergency after revoke (#7) Co-authored-by: Steffel <2143646+steffenix@users.noreply.github.com> Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com> Co-authored-by: John Bergschneider <jhb10c@my.fsu.edu> Co-authored-by: jmonteer <68742302+jmonteer@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #413 #417 #418