QC New Box Plots updated to hide zero values

Change opacity to zero to hide them.
yeastrc · Mar 5, 2020 · c583926 · c583926
1 parent 7007115
commit c583926
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 7 deletions.
diff --git a/.../qc_page/qcPageChartScanFileStatistics_MS1_PerScan_BoxPlot_IonCurrent_IonInjectionTime.js b/.../qc_page/qcPageChartScanFileStatistics_MS1_PerScan_BoxPlot_IonCurrent_IonInjectionTime.js
@@ -341,7 +341,7 @@ var QCPageChartScanFileStatistics_MS1_PerScan_BoxPlot_IonCurrent_IonInjectionTim
 
 			// const chartTitleAddition = ".  X Axis labels are Scan Numbers of MS1 Scans"
 
-			const chartTitleAddition = ".  X Axis labels are Retention Time (minutes) of MS1 Scans.   !!!! Disclaimer: For Scans with ONLY Dots at Zero, that means there is NO Data !!!!"
+			const chartTitleAddition = ".  X Axis labels are Retention Time (minutes) of MS1 Scans."; // Remove since appear to have fixed the issue  !!!! Disclaimer: For Scans with ONLY Dots at Zero, that means there is NO Data !!!!"
 
 			{
 				const $div = $("<div></div>");
@@ -592,6 +592,19 @@ var QCPageChartScanFileStatistics_MS1_PerScan_BoxPlot_IonCurrent_IonInjectionTim
 
 			// wholeChartTooltipData.push( wholeChartTooltipEntry );
 
+
+
+			let chartEntryStyle = 'color: blue;'  // style required to make visible :  color: blue; opacity: 1;
+
+			if ( singleScan_IonInjectionTime_BoxplotData.chartIntervalMax === 0 &&
+				singleScan_IonInjectionTime_BoxplotData.chartIntervalMin === 0 &&
+				singleScan_IonInjectionTime_BoxplotData.firstQuartile === 0 &&
+				singleScan_IonInjectionTime_BoxplotData.median === 0 &&
+				singleScan_IonInjectionTime_BoxplotData.thirdQuartile === 0 ) {
+
+				chartEntryStyle = 'color: white; opacity: 0;'  ///  Hide when all values are zero
+			}
+
 			var chartEntry = [ 
 				{ v: ms1_RetentionTime_MinutesDisplay, f: ms1_RetentionTime_MinutesDisplay }, //  X axis label as well as for tooltip
 				//  First list for charting for tool tips
@@ -610,10 +623,7 @@ var QCPageChartScanFileStatistics_MS1_PerScan_BoxPlot_IonCurrent_IonInjectionTim
 
 				mainBoxPlotTooltip, // tooltip for top of top box
 
-				'color: blue;'  // style required to make visible :  color: blue; opacity: 1;
-
-				//  WAS
-				// 'color: ' + colorForSearchEntry + ';'  // style required to make visible :  color: blue; opacity: 1;
+				chartEntryStyle // style required to make visible :  color: blue; opacity: 1;
 
 			];
 

diff --git a/proxl_web_app/src/main/webapp/WEB-INF/jsp-pages/viewQC.jsp b/proxl_web_app/src/main/webapp/WEB-INF/jsp-pages/viewQC.jsp
@@ -645,8 +645,12 @@ The total ion current in the bin is indicated by color, as indicated by the lege
 					
 					<div style=" display: none; " 
 						id="Scan_Statistics_Per_Scan_Ion_Injection_Time_BoxPlot_Charts_Block_Charts_Label">
-						<div style="margin-top: 10px; font-size: 18px; color: red; " >
-							!!!!  <b>Disclaimer</b>: For Scans with <b>ONLY Dots at Zero</b>, that means there is <b>NO Data</b>  !!!!
+						
+						<%--  Hide Disclaimer since appear to have fixed the problem --%>
+						<div style=" display: none; " >
+							<div style="margin-top: 10px; font-size: 18px; color: red; " >
+								!!!!  <b>Disclaimer</b>: For Scans with <b>ONLY Dots at Zero</b>, that means there is <b>NO Data</b>  !!!!
+							</div>
 						</div>
 					</div>