Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new from_dataset method to initialize objects in examples. #123

Merged
merged 9 commits into from
Jun 28, 2022
Merged

Use the new from_dataset method to initialize objects in examples. #123

merged 9 commits into from
Jun 28, 2022

Conversation

arokem
Copy link
Collaborator

@arokem arokem commented Jun 23, 2022 •
edited
Loading

Follow up on #121.

TODO:

  • Find all the examples that currently load these datasets in a few steps.
  • It's nice to have this method, but we will also want there to be an example that shows how to load your own data from CSV files step by step.
  • Mention somewhere that these CSVs are generated and point to pyAFQ and file-format spec.

@arokem arokem changed the title WIP: Use the new from_dataset method to initialize objects in examples. Use the new from_dataset method to initialize objects in examples. Jun 27, 2022
@arokem
Copy link
Collaborator Author

arokem commented Jun 27, 2022

This is ready for a review.

@richford
Copy link
Collaborator

There are some flake8 errors on build (3.9), mostly due to unused imports.

richford
richford requested changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@richford richford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one small comment. There is an explanation that worked well with the afqdata namedtumple returned by load_sarica but not with the AFQDataset instance.

examples/plot_als_classification.py Outdated Show resolved Hide resolved
@arokem @richford
Update description "namedtuple" => "AFQDataset"
18df3f9 
Co-authored-by: Adam Richie-Halford <richford@users.noreply.github.com>
@richford richford merged commit ec514b0 into yeatmanlab:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richford richford richford requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arokem @richford