Add HBN #121
Add HBN #121
Conversation
richford
added
enhancement
|
This is now running into the same version errors as #119. So I'll wait until we merge that and then rebase. |
| if verbose is not None: | ||
| download_kwargs["verbose"] = verbose | ||
|
|
||
| data_dir = downloaders[study.lower()](**download_kwargs) |
There was a problem hiding this comment.
Would it make sense to allow study to be a callable that returns the same thing that is returned here? That way, a user could define their own study downloader and pass it in here. Would that be useful?
There was a problem hiding this comment.
I think I need you to expound on this a bit. I don't quite understand what you're suggesting. We could talk about it in person. Or maybe I can come back to this after I've had more caffeine.
There was a problem hiding this comment.
After an in-person conversation, we came to the conclusion that this is probably not worth it. We anticipate this to be useful primarily in the context of datasets that get encoded explicitly in AFQ-Insight (e.g., in examples).
Also add progress bar to the url download function. And add an
AFQDataset.from_study()static method.Resolves #116