Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When we compute APM, we need to reuse CSD coefficients #590

Closed
arokem opened this issue Nov 6, 2020 · 0 comments
Closed

When we compute APM, we need to reuse CSD coefficients #590

arokem opened this issue Nov 6, 2020 · 0 comments
Labels
effort: medium A medium amount of effort needed to resolve this issue enhancement impact: low Nice features to have but low impact on the entire project

Comments

@arokem
Copy link
Collaborator

arokem commented Nov 6, 2020

Right now, when we compute APM, we run a new fit of CSD just for that (here). We should reuse previously fit CSD, if that's available. We should be able to ingest and convert SH coefficients from other pipelines (e.g., qsirecon) to compute APM.
arokem added a commit to arokem/pyAFQ that referenced this issue Nov 7, 2020
@arokem
Reuse the CSD sh coefficients if you already have them.
4aa6f8b 
Or create them for the first time to be reused later on.

This addresses some of yeatmanlab#590.
@arokem arokem mentioned this issue Nov 7, 2020
Merged
@36000 36000 added effort: medium A medium amount of effort needed to resolve this issue enhancement impact: low Nice features to have but low impact on the entire project labels Dec 11, 2020
@36000 36000 closed this as completed May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium A medium amount of effort needed to resolve this issue enhancement impact: low Nice features to have but low impact on the entire project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arokem @36000